Changeset 199598 in webkit


Ignore:
Timestamp:
Apr 15, 2016 11:24:32 AM (8 years ago)
Author:
commit-queue@webkit.org
Message:

Calling SVGAnimatedPropertyTearOff::animationEnded() will crash if the SVG property is not animating
​https://bugs.webkit.org/show_bug.cgi?id=156549

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2016-04-15
Reviewed by Darin Adler.

A speculative fix for a crash which may happen when calling animationEnded()
of any SVGAnimatedProperty while it is not animating.

  • svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::executeAction):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r199597 r199598  
     12016-04-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
     2
     3        Calling SVGAnimatedPropertyTearOff::animationEnded() will crash if the SVG property is not animating
     4        https://bugs.webkit.org/show_bug.cgi?id=156549
     5
     6        Reviewed by Darin Adler.
     7
     8        A speculative fix for a crash which may happen when calling animationEnded()
     9        of any SVGAnimatedProperty while it is not animating.
     10
     11        * svg/SVGAnimatedTypeAnimator.h:
     12        (WebCore::SVGAnimatedTypeAnimator::executeAction):
     13
    1142016-04-15  Jer Noble  <jer.noble@apple.com>
    215

  • trunk/Source/WebCore/svg/SVGAnimatedTypeAnimator.h

    r193809 r199598  
    202202            case StopAnimationAction:
    203203                ASSERT(!type);
    204                 property->animationEnded();
     204                if (property->isAnimating())
     205                    property->animationEnded();
    205206                break;
    206207            case AnimValWillChangeAction:
Note: See TracChangeset for help on using the changeset viewer.