Changeset 199736 in webkit

Timestamp:

Apr 19, 2016 12:06:47 PM (8 years ago)

Author:

youenn.fablet@crf.canon.fr

Message:

imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=155760

Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

Flakiness was coming from a callback being called after a timeout.
Timeout was set so that a double promise resolution (promise resolved
in another promise resolution callback) is done before calling the callback.
On some slow bots, the timeout was not big enough.

• web-platform-tests/streams/readable-streams/general.js: Increased the callback delay.

LayoutTests:

• TestExpectations: removed flaky expectation.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• TestExpectations (modified) (1 diff)
• imported/w3c/ChangeLog (modified) (1 diff)
• imported/w3c/web-platform-tests/streams/readable-streams/general.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-04-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
+
+        imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=155760
+
+        Reviewed by Alexey Proskuryakov.
+
+        * TestExpectations: removed flaky expectation.
+
 2016-04-19  Mark Lam  <mark.lam@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -743 +743 @@
 
 webkit.org/b/148884 imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection.html [ Pass Failure ]
-webkit.org/b/155760 imported/w3c/web-platform-tests/streams/readable-streams/general.https.html [ Pass Failure ]
 
 webkit.org/b/148922 svg/as-object/svg-in-object-dynamic-attribute-change.html [ Pass ImageOnlyFailure ]

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2016-04-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
+
+        imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=155760
+
+        Reviewed by Alexey Proskuryakov.
+
+        Flakiness was coming from a callback being called after a timeout.
+        Timeout was set so that a double promise resolution (promise resolved
+        in another promise resolution callback) is done before calling the callback.
+        On some slow bots, the timeout was not big enough.
+
+        * web-platform-tests/streams/readable-streams/general.js: Increased the callback delay.
+
 2016-04-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.js

@@ -293 +293 @@
   });
 
-  return delay(1).then(() => {
+  // WEBKIT modification: delay(1) replaced by delay(10) to ensure that pull promise is resolved before calling below thened code.
+  return delay(10).then(() => {
     assert_equals(pullCount, 1, 'pull should be called once start finishes');