Changeset 199874 in webkit

Timestamp:

Apr 22, 2016 12:54:22 AM (8 years ago)

Author:

Manuel Rego Casasnovas

Message:

[css-grid] Fix bug with positioned items in vertical writing mode
​https://bugs.webkit.org/show_bug.cgi?id=156870

Reviewed by Darin Adler.

Source/WebCore:

In RenderGrid::offsetAndBreadthForPositionedChild() we were using
directly borderLeft(), which is wrong in vertical writing modes.

To fix it we just need to use borderLogicalLeft() which is aware of
the current writing mode.

Test: fast/css-grid-layout/grid-positioned-children-writing-modes.html

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::offsetAndBreadthForPositionedChild):

LayoutTests:

Add new test to check positioned items in different writing modes
and direction combinations.

• fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html: Added.
• fast/css-grid-layout/grid-positioned-children-writing-modes.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html (added)
• LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderGrid.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-04-22  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [css-grid] Fix bug with positioned items in vertical writing mode
+        https://bugs.webkit.org/show_bug.cgi?id=156870
+
+        Reviewed by Darin Adler.
+
+        Add new test to check positioned items in different writing modes
+        and direction combinations.
+
+        * fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html: Added.
+        * fast/css-grid-layout/grid-positioned-children-writing-modes.html: Added.
+
 2016-04-21  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-04-22  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [css-grid] Fix bug with positioned items in vertical writing mode
+        https://bugs.webkit.org/show_bug.cgi?id=156870
+
+        Reviewed by Darin Adler.
+
+        In RenderGrid::offsetAndBreadthForPositionedChild() we were using
+        directly borderLeft(), which is wrong in vertical writing modes.
+
+        To fix it we just need to use borderLogicalLeft() which is aware of
+        the current writing mode.
+
+        Test: fast/css-grid-layout/grid-positioned-children-writing-modes.html
+
+        * rendering/RenderGrid.cpp:
+        (WebCore::RenderGrid::offsetAndBreadthForPositionedChild):
+
 2016-04-21  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/rendering/RenderGrid.cpp

@@ -1584 +1584 @@
             offset = LayoutUnit();
         else {
-            offset = translateRTLCoordinate(m_columnPositions[endLine]) - borderLeft();
+            offset = translateRTLCoordinate(m_columnPositions[endLine]) - borderLogicalLeft();
 
             if (endLine > firstExplicitLine && endLine < lastExplicitLine) {