Changeset 20001 in webkit


Ignore:
Timestamp:
Mar 6, 2007 8:07:42 PM (17 years ago)
Author:
bdash
Message:

2007-03-06 Mark Rowe <​mrowe@apple.com>

Reviewed by Sam Weinig.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12942
Bug 12942: ASSERTION FAILURE: qantas.com.au changing selected item in <select> via JS

Test: fast/dom/select-selectedIndex-bug-12942.html.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcListItems): Reset m_lastOnChangeIndex when recalculating list items.
  • html/HTMLSelectElement.h:

2007-03-06 Mark Rowe <​mrowe@apple.com>

Reviewed by Sam Weinig.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12942
Bug 12942: ASSERTION FAILURE: qantas.com.au changing selected item in <select> via JS

  • fast/dom/select-selectedIndex-bug-12942-expected.txt: Added.
  • fast/dom/select-selectedIndex-bug-12942.html: Added.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r19998 r20001  
     12007-03-06  Mark Rowe  <mrowe@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Test for http://bugs.webkit.org/show_bug.cgi?id=12942
     6        Bug 12942: ASSERTION FAILURE: qantas.com.au changing selected item in <select> via JS
     7
     8        * fast/dom/select-selectedIndex-bug-12942-expected.txt: Added.
     9        * fast/dom/select-selectedIndex-bug-12942.html: Added.
     10
    1112007-03-06  Mitz Pettel  <mitz@webkit.org>
    212

  • trunk/WebCore/ChangeLog

    r20000 r20001  
     12007-03-06  Mark Rowe  <mrowe@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Fix http://bugs.webkit.org/show_bug.cgi?id=12942
     6        Bug 12942: ASSERTION FAILURE: qantas.com.au changing selected item in <select> via JS
     7
     8        Test: fast/dom/select-selectedIndex-bug-12942.html.
     9
     10        * html/HTMLSelectElement.cpp:
     11        (WebCore::HTMLSelectElement::recalcListItems): Reset m_lastOnChangeIndex when recalculating list items.
     12        * html/HTMLSelectElement.h:
     13
    1142007-03-06  Brady Eidson  <beidson@apple.com>
    215

  • trunk/WebCore/html/HTMLSelectElement.cpp

    r19998 r20001  
    521521        }
    522522    }
     523    m_lastOnChangeIndex = -1;
    523524    m_recalcListItems = false;
    524525}

  • trunk/WebCore/html/HTMLSelectElement.h

    r19797 r20001  
    155155    bool m_multiple;
    156156    mutable bool m_recalcListItems;
    157     int m_lastOnChangeIndex;
    158    
     157    mutable int m_lastOnChangeIndex;
     158
    159159    int m_activeSelectionAnchorIndex;
    160     int m_activeSelectionEndIndex; 
     160    int m_activeSelectionEndIndex;
    161161    bool m_activeSelectionState;
    162162
Note: See TracChangeset for help on using the changeset viewer.