Changeset 200164 in webkit

Timestamp:

Apr 27, 2016 6:33:14 PM (8 years ago)

Author:

Simon Fraser

Message:

CSS and SVG animations should run at 60fps
​https://bugs.webkit.org/show_bug.cgi?id=157113
rdar://problem/24337280
rdar://problem/24337328

Reviewed by Dean Jackson.

For both CSS and SVG animations we used a 0.025s frame interval, which translates to
40fps. That caused these animations to look extra janky compared with accelerated
animations.

So use a 16.667ms frame interval for both.

Tested by content-animation benchmark tests.

• page/animation/AnimationController.cpp:
• svg/animation/SMILTime.h:
• svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

• svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateNextProgressTime):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/animation/AnimationController.cpp (modified) (1 diff)
• svg/animation/SMILTime.h (modified) (1 diff)
• svg/animation/SMILTimeContainer.cpp (modified) (3 diffs)
• svg/animation/SVGSMILElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-04-27  Simon Fraser  <simon.fraser@apple.com>
+
+        CSS and SVG animations should run at 60fps
+        https://bugs.webkit.org/show_bug.cgi?id=157113
+        rdar://problem/24337280
+        rdar://problem/24337328
+
+        Reviewed by Dean Jackson.
+
+        For both CSS and SVG animations we used a 0.025s frame interval, which translates to
+        40fps. That caused these animations to look extra janky compared with accelerated
+        animations.
+
+        So use a 16.667ms frame interval for both.
+
+        Tested by content-animation benchmark tests.
+
+        * page/animation/AnimationController.cpp:
+        * svg/animation/SMILTime.h:
+        * svg/animation/SMILTimeContainer.cpp:
+        (WebCore::SMILTimeContainer::updateAnimations):
+        * svg/animation/SVGSMILElement.cpp:
+        (WebCore::SVGSMILElement::calculateNextProgressTime):
+
 2016-04-27  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/page/animation/AnimationController.cpp

@@ -49 +49 @@
 namespace WebCore {
 
-static const double cAnimationTimerDelay = 0.025;
+static const double cAnimationTimerDelay = 1.0 / 60;
 static const double cBeginAnimationUpdateTimeNotSet = -1;
 

trunk/Source/WebCore/svg/animation/SMILTime.h

@@ -31 +31 @@
 
 namespace WebCore {
+
+const double SMILAnimationFrameDelay = 1.0 / 60;
 
 class SMILTime {

trunk/Source/WebCore/svg/animation/SMILTimeContainer.cpp

@@ -36 +36 @@
 namespace WebCore {
 
-static const double animationFrameDelay = 0.025;
-
 SMILTimeContainer::SMILTimeContainer(SVGSVGElement* owner) 
     : m_beginTime(0)
@@ -310 +308 @@
         m_preventScheduledAnimationsChanges = false;
 #endif
-        startTimer(earliestFireTime, animationFrameDelay);
+        startTimer(earliestFireTime, SMILAnimationFrameDelay);
         return;
     }
@@ -322 +320 @@
 #endif
 
-    startTimer(earliestFireTime, animationFrameDelay);
-}
-
-}
+    startTimer(earliestFireTime, SMILAnimationFrameDelay);
+}
+
+}

trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp

@@ -1043 +1043 @@
             return m_intervalEnd;
         } 
-        return elapsed + 0.025;
+        return elapsed + SMILAnimationFrameDelay;
     }
     return m_intervalBegin >= elapsed ? m_intervalBegin : SMILTime::unresolved();