Changeset 200343 in webkit

Timestamp:

May 2, 2016 3:19:33 PM (8 years ago)

Author:

Simon Fraser

Message:

Make Length, LengthSize and LengthPoint blending not use member functions
​https://bugs.webkit.org/show_bug.cgi?id=157281

Reviewed by Zalan Bujtas.

Having blend() be a member function is ambiguous because it's hard to tell which are
the 'from' and 'to' values. Fix Length, LengthSize and LengthPoint accordingly.

No behavior change.

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

• platform/Length.cpp:

(WebCore::blendMixedTypes):
(WebCore::blend):
(WebCore::Length::blendMixedTypes): Deleted.

• platform/Length.h:

(WebCore::Length::blend): Deleted.

• platform/LengthPoint.h:

(WebCore::blend):
(WebCore::LengthPoint::blend): Deleted.

• platform/LengthSize.h:

(WebCore::blend):
(WebCore::LengthSize::blend): Deleted.

• platform/graphics/filters/FilterOperation.cpp:

(WebCore::BlurFilterOperation::blend):

• platform/graphics/transforms/TranslateTransformOperation.cpp:

(WebCore::TranslateTransformOperation::blend):

• rendering/style/BasicShapes.cpp:

(WebCore::BasicShapePolygon::blend):
(WebCore::BasicShapeInset::blend):

• rendering/style/BasicShapes.h:

(WebCore::BasicShapeCenterCoordinate::blend):
(WebCore::BasicShapeRadius::blend):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/animation/CSSPropertyAnimation.cpp (modified) (1 diff)
• platform/Length.cpp (modified) (2 diffs)
• platform/Length.h (modified) (4 diffs)
• platform/LengthPoint.h (modified) (2 diffs)
• platform/LengthSize.h (modified) (1 diff)
• platform/graphics/filters/FilterOperation.cpp (modified) (1 diff)
• platform/graphics/transforms/TranslateTransformOperation.cpp (modified) (2 diffs)
• rendering/style/BasicShapes.cpp (modified) (2 diffs)
• rendering/style/BasicShapes.h (modified) (8 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-05-02  Simon Fraser  <simon.fraser@apple.com>
+
+        Make Length, LengthSize and LengthPoint blending not use member functions
+        https://bugs.webkit.org/show_bug.cgi?id=157281
+
+        Reviewed by Zalan Bujtas.
+
+        Having blend() be a member function is ambiguous because it's hard to tell which are
+        the 'from' and 'to' values. Fix Length, LengthSize and LengthPoint accordingly.
+
+        No behavior change.
+
+        * page/animation/CSSPropertyAnimation.cpp:
+        (WebCore::blendFunc):
+        * platform/Length.cpp:
+        (WebCore::blendMixedTypes):
+        (WebCore::blend):
+        (WebCore::Length::blendMixedTypes): Deleted.
+        * platform/Length.h:
+        (WebCore::Length::blend): Deleted.
+        * platform/LengthPoint.h:
+        (WebCore::blend):
+        (WebCore::LengthPoint::blend): Deleted.
+        * platform/LengthSize.h:
+        (WebCore::blend):
+        (WebCore::LengthSize::blend): Deleted.
+        * platform/graphics/filters/FilterOperation.cpp:
+        (WebCore::BlurFilterOperation::blend):
+        * platform/graphics/transforms/TranslateTransformOperation.cpp:
+        (WebCore::TranslateTransformOperation::blend):
+        * rendering/style/BasicShapes.cpp:
+        (WebCore::BasicShapePolygon::blend):
+        (WebCore::BasicShapeInset::blend):
+        * rendering/style/BasicShapes.h:
+        (WebCore::BasicShapeCenterCoordinate::blend):
+        (WebCore::BasicShapeRadius::blend):
+
 2016-05-02  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp

@@ -85 +85 @@
 static inline Length blendFunc(const AnimationBase*, const Length& from, const Length& to, double progress)
 {
-    return to.blend(from, progress);
+    return blend(from, to, progress);
 }
 

trunk/Source/WebCore/platform/Length.cpp

@@ -252 +252 @@
     m_calculationValueHandle = calculationValues().insert(WTFMove(value));
 }
-        
-Length Length::blendMixedTypes(const Length& from, double progress) const
-{
-    if (progress <= 0.0)
-        return from;
-        
-    if (progress >= 1.0)
-        return *this;
-        
-    auto blend = std::make_unique<CalcExpressionBlendLength>(from, *this, progress);
-    return Length(CalculationValue::create(WTFMove(blend), CalculationRangeAll));
-}
 
 CalculationValue& Length::calculationValue() const
@@ -295 +283 @@
 {
     return calculationValue() == other.calculationValue();
+}
+
+static Length blendMixedTypes(const Length& from, const Length& to, double progress)
+{
+    if (progress <= 0.0)
+        return from;
+        
+    if (progress >= 1.0)
+        return to;
+        
+    auto blend = std::make_unique<CalcExpressionBlendLength>(from, to, progress);
+    return Length(CalculationValue::create(WTFMove(blend), CalculationRangeAll));
+}
+
+Length blend(const Length& from, const Length& to, double progress)
+{
+    if (from.type() == Calculated || to.type() == Calculated)
+        return blendMixedTypes(from, to, progress);
+
+    if (!from.isZero() && !to.isZero() && from.type() != to.type())
+        return blendMixedTypes(from, to, progress);
+
+    if (from.isZero() && to.isZero())
+        return progress ? to : from; // Pick up 'auto' from 'from' if progress is zero.
+
+    LengthType resultType = to.type();
+    if (to.isZero())
+        resultType = from.type();
+
+    if (resultType == Percent) {
+        float fromPercent = from.isZero() ? 0 : from.percent();
+        float toPercent = to.isZero() ? 0 : to.percent();
+        return Length(WebCore::blend(fromPercent, toPercent, progress), Percent);
+    }
+
+    float fromValue = from.isZero() ? 0 : from.value();
+    float toValue = to.isZero() ? 0 : to.value();
+    return Length(WebCore::blend(fromValue, toValue, progress), resultType);
 }
 

trunk/Source/WebCore/platform/Length.h

@@ -108 +108 @@
     bool isSpecifiedOrIntrinsic() const;
 
-    // Blend two lengths to produce a new length that is in between them. Used for animation.
-    // FIXME: Why is this a member function?
-    Length blend(const Length& from, double progress) const;
-
     float nonNanCalculatedValue(int maxValue) const;
 
@@ -118 +114 @@
 
     bool isCalculatedEqual(const Length&) const;
-    Length blendMixedTypes(const Length& from, double progress) const;
 
     WEBCORE_EXPORT void ref() const;
@@ -133 +128 @@
 };
 
+// Blend two lengths to produce a new length that is in between them. Used for animation.
+Length blend(const Length& from, const Length& to, double progress);
+
 std::unique_ptr<Length[]> newCoordsArray(const String&, int& length);
 std::unique_ptr<Length[]> newLengthArray(const String&, int& length);
@@ -413 +411 @@
 }
 
-// FIXME: Does this need to be in the header? Is it valuable to inline? Does it get inlined?
-inline Length Length::blend(const Length& from, double progress) const
-{
-    if (from.type() == Calculated || type() == Calculated)
-        return blendMixedTypes(from, progress);
-
-    if (!from.isZero() && !isZero() && from.type() != type())
-        return blendMixedTypes(from, progress);
-
-    if (from.isZero() && isZero())
-        return progress ? *this : from; // Pick up 'auto' from 'from' if progress is zero.
-
-    LengthType resultType = type();
-    if (isZero())
-        resultType = from.type();
-
-    if (resultType == Percent) {
-        float fromPercent = from.isZero() ? 0 : from.percent();
-        float toPercent = isZero() ? 0 : percent();
-        return Length(WebCore::blend(fromPercent, toPercent, progress), Percent);
-    }
-
-    float fromValue = from.isZero() ? 0 : from.value();
-    float toValue = isZero() ? 0 : value();
-    return Length(WebCore::blend(fromValue, toValue, progress), resultType);
-}
-
 TextStream& operator<<(TextStream&, Length);
 

trunk/Source/WebCore/platform/LengthPoint.h

@@ -59 +59 @@
     const Length& y() const { return m_y; }
 
-    LengthPoint blend(const LengthPoint& from, double progress) const
-    {
-        return LengthPoint(m_x.blend(from.x(), progress), m_y.blend(from.y(), progress));
-    }
-
 private:
     // FIXME: it would be nice to pack the two Lengths together better somehow (to avoid padding between them).
@@ -70 +65 @@
 };
 
+inline LengthPoint blend(const LengthPoint& from, const LengthPoint& to, double progress)
+{
+    return LengthPoint(blend(from.x(), to.x(), progress), blend(from.y(), to.y(), progress));
+}
+
 TextStream& operator<<(TextStream&, const LengthPoint&);
 

trunk/Source/WebCore/platform/LengthSize.h

@@ -49 +49 @@
     const Length& height() const { return m_height; }
 
-    LengthSize blend(const LengthSize& from, double progress) const
-    {
-        return LengthSize(m_width.blend(from.width(), progress), m_height.blend(from.height(), progress));
-    }
-
 private:
     Length m_width;
     Length m_height;
 };
+
+inline LengthSize blend(const LengthSize& from, const LengthSize& to, double progress)
+{
+    return LengthSize(blend(from.width(), to.width(), progress), blend(from.height(), to.height(), progress));
+}
 
 TextStream& operator<<(TextStream&, const LengthSize&);

trunk/Source/WebCore/platform/graphics/filters/FilterOperation.cpp

@@ -163 +163 @@
 
     if (blendToPassthrough)
-        return BlurFilterOperation::create(Length(lengthType).blend(m_stdDeviation, progress));
+        return BlurFilterOperation::create(WebCore::blend(m_stdDeviation, Length(lengthType), progress));
 
     const BlurFilterOperation* fromOperation = downcast<BlurFilterOperation>(from);
     Length fromLength = fromOperation ? fromOperation->m_stdDeviation : Length(lengthType);
-    return BlurFilterOperation::create(m_stdDeviation.blend(fromLength, progress));
+    return BlurFilterOperation::create(WebCore::blend(fromLength, m_stdDeviation, progress));
 }
     

trunk/Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.cpp

@@ -43 +43 @@
     Length zeroLength(0, Fixed);
     if (blendToIdentity)
-        return TranslateTransformOperation::create(zeroLength.blend(m_x, progress), zeroLength.blend(m_y, progress), zeroLength.blend(m_z, progress), m_type);
+        return TranslateTransformOperation::create(WebCore::blend(m_x, zeroLength, progress), WebCore::blend(m_y, zeroLength, progress), WebCore::blend(m_z, zeroLength, progress), m_type);
 
     const TranslateTransformOperation* fromOp = downcast<TranslateTransformOperation>(from);
@@ -49 +49 @@
     Length fromY = fromOp ? fromOp->m_y : zeroLength;
     Length fromZ = fromOp ? fromOp->m_z : zeroLength;
-    return TranslateTransformOperation::create(m_x.blend(fromX, progress), m_y.blend(fromY, progress), m_z.blend(fromZ, progress), m_type);
+    return TranslateTransformOperation::create(WebCore::blend(fromX, x(), progress), WebCore::blend(fromY, y(), progress), WebCore::blend(fromZ, z(), progress), m_type);
 }
 

trunk/Source/WebCore/rendering/style/BasicShapes.cpp

@@ -320 +320 @@
 
     for (size_t i = 0; i < length; i = i + 2) {
-        result->appendPoint(m_values.at(i).blend(otherPolygon.values().at(i), progress),
-            m_values.at(i + 1).blend(otherPolygon.values().at(i + 1), progress));
+        result->appendPoint(
+            WebCore::blend(otherPolygon.values().at(i), m_values.at(i), progress),
+            WebCore::blend(otherPolygon.values().at(i + 1), m_values.at(i + 1), progress));
     }
 
@@ -412 +413 @@
 }
 
-Ref<BasicShape> BasicShapeInset::blend(const BasicShape& other, double progress) const
-{
-    ASSERT(type() == other.type());
-
-    auto& otherInset = downcast<BasicShapeInset>(other);
+Ref<BasicShape> BasicShapeInset::blend(const BasicShape& from, double progress) const
+{
+    ASSERT(type() == from.type());
+
+    auto& fromInset = downcast<BasicShapeInset>(from);
     auto result =  BasicShapeInset::create();
-    result->setTop(m_top.blend(otherInset.top(), progress));
-    result->setRight(m_right.blend(otherInset.right(), progress));
-    result->setBottom(m_bottom.blend(otherInset.bottom(), progress));
-    result->setLeft(m_left.blend(otherInset.left(), progress));
-
-    result->setTopLeftRadius(m_topLeftRadius.blend(otherInset.topLeftRadius(), progress));
-    result->setTopRightRadius(m_topRightRadius.blend(otherInset.topRightRadius(), progress));
-    result->setBottomRightRadius(m_bottomRightRadius.blend(otherInset.bottomRightRadius(), progress));
-    result->setBottomLeftRadius(m_bottomLeftRadius.blend(otherInset.bottomLeftRadius(), progress));
+    result->setTop(WebCore::blend(fromInset.top(), top(), progress));
+    result->setRight(WebCore::blend(fromInset.right(), right(), progress));
+    result->setBottom(WebCore::blend(fromInset.bottom(), bottom(), progress));
+    result->setLeft(WebCore::blend(fromInset.left(), left(), progress));
+
+    result->setTopLeftRadius(WebCore::blend(fromInset.topLeftRadius(), topLeftRadius(), progress));
+    result->setTopRightRadius(WebCore::blend(fromInset.topRightRadius(), topRightRadius(), progress));
+    result->setBottomRightRadius(WebCore::blend(fromInset.bottomRightRadius(), bottomRightRadius(), progress));
+    result->setBottomLeftRadius(WebCore::blend(fromInset.bottomLeftRadius(), bottomLeftRadius(), progress));
 
     return WTFMove(result);

trunk/Source/WebCore/rendering/style/BasicShapes.h

@@ -65 +65 @@
 
     virtual bool canBlend(const BasicShape&) const = 0;
-    virtual Ref<BasicShape> blend(const BasicShape&, double) const = 0;
+    virtual Ref<BasicShape> blend(const BasicShape& from, double) const = 0;
 
     virtual bool operator==(const BasicShape&) const = 0;
@@ -102 +102 @@
     const Length& computedLength() const { return m_computedLength; }
 
-    BasicShapeCenterCoordinate blend(const BasicShapeCenterCoordinate& other, double progress) const
-    {
-        return BasicShapeCenterCoordinate(TopLeft, m_computedLength.blend(other.m_computedLength, progress));
+    BasicShapeCenterCoordinate blend(const BasicShapeCenterCoordinate& from, double progress) const
+    {
+        return BasicShapeCenterCoordinate(TopLeft, WebCore::blend(from.m_computedLength, m_computedLength, progress));
     }
     
@@ -156 +156 @@
     }
 
-    BasicShapeRadius blend(const BasicShapeRadius& other, double progress) const
-    {
-        if (m_type != Value || other.type() != Value)
-            return BasicShapeRadius(other);
-
-        return BasicShapeRadius(m_value.blend(other.value(), progress));
+    BasicShapeRadius blend(const BasicShapeRadius& from, double progress) const
+    {
+        if (m_type != Value || from.type() != Value)
+            return BasicShapeRadius(from);
+
+        return BasicShapeRadius(WebCore::blend(from.value(), value(), progress));
     }
     
@@ -196 +196 @@
 
     bool canBlend(const BasicShape&) const override;
-    Ref<BasicShape> blend(const BasicShape&, double) const override;
+    Ref<BasicShape> blend(const BasicShape& from, double) const override;
 
     bool operator==(const BasicShape&) const override;
@@ -228 +228 @@
 
     bool canBlend(const BasicShape&) const override;
-    Ref<BasicShape> blend(const BasicShape&, double) const override;
+    Ref<BasicShape> blend(const BasicShape& from, double) const override;
 
     bool operator==(const BasicShape&) const override;
@@ -259 +259 @@
 
     bool canBlend(const BasicShape&) const override;
-    Ref<BasicShape> blend(const BasicShape&, double) const override;
+    Ref<BasicShape> blend(const BasicShape& from, double) const override;
 
     bool operator==(const BasicShape&) const override;
@@ -287 +287 @@
 
     bool canBlend(const BasicShape&) const override;
-    Ref<BasicShape> blend(const BasicShape&, double) const override;
+    Ref<BasicShape> blend(const BasicShape& from, double) const override;
 
     bool operator==(const BasicShape&) const override;
@@ -327 +327 @@
 
     bool canBlend(const BasicShape&) const override;
-    Ref<BasicShape> blend(const BasicShape&, double) const override;
+    Ref<BasicShape> blend(const BasicShape& from, double) const override;
 
     bool operator==(const BasicShape&) const override;