Changeset 200938 in webkit


Ignore:
Timestamp:
May 15, 2016 11:23:36 PM (8 years ago)
Author:
fred.wang@free.fr
Message:

Small removal of useless code for MathML token elements
https://bugs.webkit.org/show_bug.cgi?id=157568

Patch by Frederic Wang <fwang@igalia.com> on 2016-05-15
Reviewed by Darin Adler.

We remove two pieces of code for MathML token elements with unclear purposes and that do not
have any effect on math rendering.

No new tests, behavior is unchanged.

  • css/mathml.css:

(mtext): Deleted. This was probably a hack that is no longer needed with the latest math font
ascent/descent management.

  • mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::createElementRenderer): Deleted. Removing this does not break
the mentioned test.

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r200934 r200938  
     12016-05-15  Frederic Wang  <fwang@igalia.com>
     2
     3        Small removal of useless code for MathML token elements
     4        https://bugs.webkit.org/show_bug.cgi?id=157568
     5
     6        Reviewed by Darin Adler.
     7
     8        We remove two pieces of code for MathML token elements with unclear purposes and that do not
     9        have any effect on math rendering.
     10
     11        No new tests, behavior is unchanged.
     12
     13        * css/mathml.css:
     14        (mtext): Deleted. This was probably a hack that is no longer needed with the latest math font
     15        ascent/descent management.
     16        * mathml/MathMLTextElement.cpp:
     17        (WebCore::MathMLTextElement::createElementRenderer): Deleted. Removing this does not break
     18        the mentioned test.
     19
    1202016-05-15  Chris Dumez  <cdumez@apple.com>
    221
  • trunk/Source/WebCore/css/mathml.css

    r199869 r200938  
    9494    /* FIXME: Should we reset more CSS properties (http://webkit.org/b/156839)? */
    9595}
    96 mtext {
    97     line-height: 1.0;
    98 }
    9996
    10097math {
  • trunk/Source/WebCore/mathml/MathMLTextElement.cpp

    r200041 r200938  
    8787    ASSERT(hasTagName(MathMLNames::miTag) || hasTagName(MathMLNames::mnTag) || hasTagName(MathMLNames::msTag) || hasTagName(MathMLNames::mtextTag));
    8888
    89     // FIXME: why do we have to set the alignment here ? It seems needed to make the
    90     // style-changed.htmt test to pass, since mathml renders expect Stretch as default.
    91     style.setAlignItemsPosition(ItemPositionStretch);
    92 
    9389    return createRenderer<RenderMathMLToken>(*this, WTFMove(style));
    9490}
Note: See TracChangeset for help on using the changeset viewer.