Changeset 201416 in webkit

Timestamp:

May 25, 2016, 11:50:26 PM (9 years ago)

Author:

Antti Koivisto

Message:

Invalidate style for newly added nodes in Node::insertedInto
​https://bugs.webkit.org/show_bug.cgi?id=158088

Reviewed by Darin Adler.

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::parserAppendChild):
(WebCore::ContainerNode::childrenChanged):
(WebCore::ContainerNode::updateTreeAfterInsertion):

• dom/Node.cpp:

(WebCore::Node::insertedInto):

Consolidate setNeedsStyleRecalc(ReconstructRenderTree) here.

This also now happens earliest possible time, right after inserting the node and can avoid
some unneeded style invalidation work in subclass insertion handlers.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/ContainerNode.cpp (modified) (3 diffs)
• dom/Node.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-05-25  Antti Koivisto  <antti@apple.com>
+
+        Invalidate style for newly added nodes in Node::insertedInto
+        https://bugs.webkit.org/show_bug.cgi?id=158088
+
+        Reviewed by Darin Adler.
+
+        * dom/ContainerNode.cpp:
+        (WebCore::ContainerNode::parserInsertBefore):
+        (WebCore::ContainerNode::replaceChild):
+        (WebCore::ContainerNode::parserAppendChild):
+        (WebCore::ContainerNode::childrenChanged):
+        (WebCore::ContainerNode::updateTreeAfterInsertion):
+        * dom/Node.cpp:
+        (WebCore::Node::insertedInto):
+
+        Consolidate setNeedsStyleRecalc(ReconstructRenderTree) here.
+
+        This also now happens earliest possible time, right after inserting the node and can avoid
+        some unneeded style invalidation work in subclass insertion handlers.
+
 2016-05-25  Yoav Weiss  <yoav@yoav.ws>
 

trunk/Source/WebCore/dom/ContainerNode.cpp

@@ -377 +377 @@
 
     notifyChildInserted(newChild, ChildChangeSourceParser);
-
-    newChild.setNeedsStyleRecalc(ReconstructRenderTree);
 }
 
@@ -722 +720 @@
 
     notifyChildInserted(newChild, ChildChangeSourceParser);
-
-    newChild.setNeedsStyleRecalc(ReconstructRenderTree);
 }
 
@@ -815 +811 @@
     notifyChildInserted(child, ChildChangeSourceAPI);
 
-    child.setNeedsStyleRecalc(ReconstructRenderTree);
-
     dispatchChildInsertionEvents(child);
 }

trunk/Source/WebCore/dom/Node.cpp

@@ -1163 +1163 @@
     if (parentOrShadowHostNode()->isInShadowTree())
         setFlag(IsInShadowTreeFlag);
+
+    setNeedsStyleRecalc(ReconstructRenderTree);
+
     return InsertionDone;
 }