Changeset 201466 in webkit

Timestamp:

May 27, 2016 1:32:42 PM (8 years ago)

Author:

akling@apple.com

Message:

Document abandons its EventTargetData.
<​https://webkit.org/b/158158>

Reviewed by Darin Adler.

Node::willBeDeletedFrom() is called when destroying all Node types *except* Document.
If a Document had an associated EventTargetData, it would not get cleaned up.

This patch moves the EventTargetData cleanup to ~Node() where it's guaranteed to run.

• dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::willBeDeletedFrom):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Node.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-05-27  Andreas Kling  <akling@apple.com>
+
+        Document abandons its EventTargetData.
+        <https://webkit.org/b/158158>
+
+        Reviewed by Darin Adler.
+
+        Node::willBeDeletedFrom() is called when destroying all Node types *except* Document.
+        If a Document had an associated EventTargetData, it would not get cleaned up.
+
+        This patch moves the EventTargetData cleanup to ~Node() where it's guaranteed to run.
+
+        * dom/Node.cpp:
+        (WebCore::Node::~Node):
+        (WebCore::Node::willBeDeletedFrom):
+
 2016-05-27  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/dom/Node.cpp

@@ -306 +306 @@
         willBeDeletedFrom(document());
 
+    if (hasEventTargetData())
+        clearEventTargetData();
+
     document().decrementReferencingNodeCount();
 }
@@ -318 +321 @@
         // FIXME: This should call didRemoveTouchEventHandler().
 #endif
-        clearEventTargetData();
     }