Changeset 201639 in webkit

Timestamp:

Jun 3, 2016 12:52:13 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION: WebGL doesn't show up in CSS reflections
​https://bugs.webkit.org/show_bug.cgi?id=76489

Patch by Antoine Quint <Antoine Quint> on 2016-06-03
Reviewed by Dean Jackson.

Source/WebCore:

The WebGLLayer needs to notify its owning GraphicsLayer that it was displayed
such that its clones, in GraphicsLayerCA::layerDidDisplay, may have their contents
updated to match that layer's contents. The test at compositing/webgl/webgl-reflection.html
already covers this test and its expectation on Mac has been updated.

• platform/graphics/mac/WebGLLayer.mm:

(-[WebGLLayer display]):

LayoutTests:

Update the expected rendering to contain the reflected WebGL <canvas>.

• platform/mac/compositing/webgl/webgl-reflection-expected.png:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/compositing/webgl/webgl-reflection-expected.png (modified) (previous)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/mac/WebGLLayer.mm (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-06-03  Antoine Quint  <graouts@apple.com>
+
+        REGRESSION: WebGL doesn't show up in CSS reflections
+        https://bugs.webkit.org/show_bug.cgi?id=76489
+
+        Reviewed by Dean Jackson.
+
+        Update the expected rendering to contain the reflected WebGL <canvas>.
+
+        * platform/mac/compositing/webgl/webgl-reflection-expected.png:
+
 2016-06-02  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-03  Antoine Quint  <graouts@apple.com>
+
+        REGRESSION: WebGL doesn't show up in CSS reflections
+        https://bugs.webkit.org/show_bug.cgi?id=76489
+
+        Reviewed by Dean Jackson.
+
+        The WebGLLayer needs to notify its owning GraphicsLayer that it was displayed
+        such that its clones, in GraphicsLayerCA::layerDidDisplay, may have their contents
+        updated to match that layer's contents. The test at compositing/webgl/webgl-reflection.html
+        already covers this test and its expectation on Mac has been updated.
+
+        * platform/graphics/mac/WebGLLayer.mm:
+        (-[WebGLLayer display]):
+
 2016-06-02  Gavin Barraclough  <barraclough@apple.com>
 

trunk/Source/WebCore/platform/graphics/mac/WebGLLayer.mm

@@ -33 +33 @@
 #import "GraphicsContextCG.h"
 #import "GraphicsLayer.h"
+#import "GraphicsLayerCA.h"
+#import "PlatformCALayer.h"
 #import <wtf/FastMalloc.h>
 #import <wtf/RetainPtr.h>
@@ -180 +182 @@
 #endif
     _context->markLayerComposited();
+    PlatformCALayer* layer = PlatformCALayer::platformCALayer(self);
+    if (layer && layer->owner())
+        layer->owner()->platformCALayerLayerDidDisplay(layer);
 }