Changeset 201650 in webkit

Timestamp:

Jun 3, 2016, 11:36:13 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Update NativeFunctionParameters (FontFaceSet, HTMLSlotElement, EventTarget)
​https://bugs.webkit.org/show_bug.cgi?id=158333

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-03
Reviewed by Brian Burg.

• UserInterface/Models/NativeFunctionParameters.js:

Replace FontLoader with FontFaceSet. Add HTMLSlotElement API.
EventTarget is now actually in the prototype chain, so add it as
a first class citizen and keep mixing it in for legacy backends.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/NativeFunctionParameters.js (modified) (4 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-06-03  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Update NativeFunctionParameters (FontFaceSet, HTMLSlotElement, EventTarget)
+        https://bugs.webkit.org/show_bug.cgi?id=158333
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Models/NativeFunctionParameters.js:
+        Replace FontLoader with FontFaceSet. Add HTMLSlotElement API.
+        EventTarget is now actually in the prototype chain, so add it as
+        a first class citizen and keep mixing it in for legacy backends.
+
 2016-06-02  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js

@@ -839 +839 @@
     },
 
-    FontLoader: {
-        checkFont: "font, [text]",
-        loadFont: "params",
-        notifyWhenFontsReady: "callback",
+    FontFaceSet: {
+        add: "font",
+        check: "font, [text=\" \"]",
+        delete: "font",
+        load: "font, [text=\" \"]",
         __proto__: null,
     },
@@ -953 +954 @@
         namedItem: "[name]",
         setCustomValidity: "error",
+        __proto__: null,
+    },
+
+    HTMLSlotElement: {
+        assignedNodes: "[options]",
         __proto__: null,
     },
@@ -2143 +2149 @@
         __proto__: null,
     },
-};
-
-(function() {
-    var EventTarget = {
+
+    EventTarget: {
         addEventListener: "type, listener, [useCapture=false]",
         removeEventListener: "type, listener, [useCapture=false]",
         dispatchEvent: "event",
-    };
-
+        __proto__: null,
+    },
+};
+
+(function() {
+    // COMPATIBILITY (iOS 9): EventTarget properties were on instances, now there
+    // is an actual EventTarget prototype in the chain.
+    var EventTarget = WebInspector.NativePrototypeFunctionParameters.EventTarget;
     var eventTargetTypes = [
         "Node", "Window",
-        "AudioNode", "AudioTrackList", "DOMApplicationCache", "FileReader", "FontLoader",
+        "AudioNode", "AudioTrackList", "DOMApplicationCache", "FileReader",
         "MediaController", "MediaStreamTrack", "MessagePort", "Notification", "RTCDTMFSender",
         "SpeechSynthesisUtterance", "TextTrack", "TextTrackCue", "TextTrackList",
@@ -2160 +2170 @@
         "WorkerGlobalScope", "XMLHttpRequest", "webkitMediaStream", "webkitRTCPeerConnection"
     ];
-
     for (var type of eventTargetTypes)
         Object.assign(WebInspector.NativePrototypeFunctionParameters[type], EventTarget);