Changeset 201680 in webkit

Timestamp:

Jun 4, 2016 11:58:08 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Add better basic isNaN test coverage
​https://bugs.webkit.org/show_bug.cgi?id=158379

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-04
Reviewed by Benjamin Poulain.

• js/Number-isNaN-expected.txt: Added.
• js/Number-isNaN.html: Added.
• js/global-isNaN-expected.txt: Added.
• js/global-isNaN.html: Added.
• js/script-tests/Number-isNaN.js: Added.

(objectWithNumberValueOf.valueOf):
(objectWithNaNValueOf.valueOf):
(objectRecordConversionCalls.toString):
(objectRecordConversionCalls.valueOf):

• js/script-tests/global-isNaN.js: Added.

(objectConvertToString.toString):
(objectRecordToStringCall.toString):
(objectThrowOnToString.toString):
(objectWithValueOf.valueOf):
(objectThrowOnValueOf.valueOf):
(objectThrowOnValueOf.toString):
(objectRecordValueOfCall.valueOf):
(objectRecordConversionCalls.toString):
(objectRecordConversionCalls.valueOf):

• js/script-tests/math-clz32.js:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/Number-isNaN-expected.txt (added)
• LayoutTests/js/Number-isNaN.html (added)
• LayoutTests/js/global-isNaN-expected.txt (added)
• LayoutTests/js/global-isNaN.html (added)
• LayoutTests/js/script-tests/Number-isNaN.js (added)
• LayoutTests/js/script-tests/global-isNaN.js (added)
• LayoutTests/js/script-tests/math-clz32.js (modified) (1 diff)
• Source/JavaScriptCore/tests/stress/math-clz32-basics.js (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-06-04  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Add better basic isNaN test coverage
+        https://bugs.webkit.org/show_bug.cgi?id=158379
+
+        Reviewed by Benjamin Poulain.
+
+        * js/Number-isNaN-expected.txt: Added.
+        * js/Number-isNaN.html: Added.
+        * js/global-isNaN-expected.txt: Added.
+        * js/global-isNaN.html: Added.
+        * js/script-tests/Number-isNaN.js: Added.
+        (objectWithNumberValueOf.valueOf):
+        (objectWithNaNValueOf.valueOf):
+        (objectRecordConversionCalls.toString):
+        (objectRecordConversionCalls.valueOf):
+        * js/script-tests/global-isNaN.js: Added.
+        (objectConvertToString.toString):
+        (objectRecordToStringCall.toString):
+        (objectThrowOnToString.toString):
+        (objectWithValueOf.valueOf):
+        (objectThrowOnValueOf.valueOf):
+        (objectThrowOnValueOf.toString):
+        (objectRecordValueOfCall.valueOf):
+        (objectRecordConversionCalls.toString):
+        (objectRecordConversionCalls.valueOf):
+        * js/script-tests/math-clz32.js:
+
 2016-06-04  Brent Fulgham  <bfulgham@apple.com>
 

trunk/LayoutTests/js/script-tests/math-clz32.js

@@ -7 +7 @@
 // Function properties.
 shouldBe('Math.clz32.length', '1');
-shouldBeEqualToString('Math.clz32.name', 'clz32')
+shouldBeEqualToString('Math.clz32.name', 'clz32');
 shouldBe('Object.getOwnPropertyDescriptor(Math, "clz32").configurable', 'true');
 shouldBe('Object.getOwnPropertyDescriptor(Math, "clz32").enumerable', 'false');

trunk/Source/JavaScriptCore/tests/stress/math-clz32-basics.js

@@ -57 +57 @@
     var clzMinusZero = mathClz32OnInteger(-0);
     if (clzMinusZero != 32)
-        throw "mathClz32OnInteger(\"-0\") = " + clzMinusZero;
+        throw "mathClz32OnInteger(-0) = " + clzMinusZero;
 }
 noInline(verifyMathClz32OnIntegerWithOtherTypes);
@@ -71 +71 @@
     return Math.clz32(value);
 }
-noInline(mathClz32OnInteger);
-
-// Test simple cases on integers.
+noInline(mathClz32OnDouble);
+
+// Test simple cases on doubles.
 function testMathClz32OnDoubles()
 {
@@ -90 +90 @@
     var value = mathClz32OnDouble(-0);
     if (value != 32)
-        throw "mathClz32OnDouble(0) = " + value;
+        throw "mathClz32OnDouble(-0) = " + value;
 
     var value = mathClz32OnDouble(NaN);