Changeset 201726 in webkit


Ignore:
Timestamp:
Jun 6, 2016 1:34:07 PM (8 years ago)
Author:
clopez@igalia.com
Message:

REGRESSION(r201449) [GTK] ARMv7 build fails with libicudata.so.55: cannot open shared object file on gtkdoc-scangobj step.
​https://bugs.webkit.org/show_bug.cgi?id=158417

Reviewed by Michael Catanzaro.

The toolchain on armhf (ARMv7) seems unable to properly handle
a shared library that doesn't link with anything.

And libicudata is built by default in this way because it only
contains static data.

That makes icu unusable on armhf because the linker will be
unable to resolve the libicudata dependencies.

Most (if not all) distributions workaround this by linking
libicudata with libc6, which is already a needed dependency for
any of the other icu shared libraries.

So import here the Debian patch fixing this issue. For further
details check ​https://bugs.debian.org/653457

  • gtk/jhbuild.modules:
  • gtk/patches/icudata-stdlibs.patch: Added.
Location:
trunk/Tools
Files:
1 added
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r201720 r201726  
     12016-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
     2
     3        REGRESSION(r201449) [GTK] ARMv7 build fails with libicudata.so.55: cannot open shared object file on gtkdoc-scangobj step.
     4        https://bugs.webkit.org/show_bug.cgi?id=158417
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        The toolchain on armhf (ARMv7) seems unable to properly handle
     9        a shared library that doesn't link with anything.
     10
     11        And libicudata is built by default in this way because it only
     12        contains static data.
     13
     14        That makes icu unusable on armhf because the linker will be
     15        unable to resolve the libicudata dependencies.
     16
     17        Most (if not all) distributions workaround this by linking
     18        libicudata with libc6, which is already a needed dependency for
     19        any of the other icu shared libraries.
     20
     21        So import here the Debian patch fixing this issue. For further
     22        details check https://bugs.debian.org/653457
     23
     24        * gtk/jhbuild.modules:
     25        * gtk/patches/icudata-stdlibs.patch: Added.
     26
    1272016-06-06  Per Arne Vollan  <pvollan@apple.com>
    228

  • trunk/Tools/gtk/jhbuild.modules

    r201509 r201726  
    497497            repo="webkitgtk-jhbuild-mirror"
    498498            hash="sha256:e16b22cbefdd354bec114541f7849a12f8fc2015320ca5282ee4fd787571457b">
     499      <patch file="icudata-stdlibs.patch" strip="1"/>
    499500    </branch>
    500501  </autotools>
Note: See TracChangeset for help on using the changeset viewer.