Changeset 201732 in webkit


Ignore:
Timestamp:
Jun 6, 2016 4:38:48 PM (8 years ago)
Author:
akling@apple.com
Message:

Don't reportAbandonedObjectGraph() after throwing out linked code or RegExps.
<https://webkit.org/b/158444>

Unreviewed.

This is a speculative change for iOS performance bots. The calls to reportAbandonedObjectGraph
were basically redundant, since mainframe navigation will cause GC acceleration anyway via
ScriptController.

This appears successful at recovering the ~0.7% regression I could reproduce locally on newer
hardware but it's a bit too noisy to say for sure.

  • runtime/VM.cpp:

(JSC::VM::deleteAllLinkedCode):
(JSC::VM::deleteAllRegExpCode):

Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r201725 r201732  
     12016-06-06  Andreas Kling  <akling@apple.com>
     2
     3        Don't reportAbandonedObjectGraph() after throwing out linked code or RegExps.
     4        <https://webkit.org/b/158444>
     5
     6        Unreviewed.
     7
     8        This is a speculative change for iOS performance bots. The calls to reportAbandonedObjectGraph
     9        were basically redundant, since mainframe navigation will cause GC acceleration anyway via
     10        ScriptController.
     11
     12        This appears successful at recovering the ~0.7% regression I could reproduce locally on newer
     13        hardware but it's a bit too noisy to say for sure.
     14
     15        * runtime/VM.cpp:
     16        (JSC::VM::deleteAllLinkedCode):
     17        (JSC::VM::deleteAllRegExpCode):
     18
    1192016-06-06  Skachkov Oleksandr  <gskachkov@gmail.com>
    220        [ESNext] Trailing commas in function parameters.
  • trunk/Source/JavaScriptCore/runtime/VM.cpp

    r201654 r201732  
    550550    whenIdle([this]() {
    551551        heap.deleteAllCodeBlocks();
    552         heap.reportAbandonedObjectGraph();
    553552    });
    554553}
     
    558557    whenIdle([this]() {
    559558        m_regExpCache->deleteAllCode();
    560         heap.reportAbandonedObjectGraph();
    561559    });
    562560}
Note: See TracChangeset for help on using the changeset viewer.