Changeset 201848 in webkit

Timestamp:

Jun 8, 2016, 7:05:26 PM (9 years ago)

Author:

benjamin@webkit.org

Message:

Change thresholdForOptimizeSoon to match thresholdForOptimizeAfterWarmUp

Unreviewed.

This adds back the assertion removed in r201845.
Making those threshold equal is completely perf neutral
(on Haswell rMBP with 20 runs).

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-06-08

• runtime/Options.cpp:

(JSC::Options::initialize):

• runtime/Options.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/Options.cpp (modified) (1 diff)
• runtime/Options.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-06-08  Benjamin Poulain  <bpoulain@apple.com>
+
+        Change thresholdForOptimizeSoon to match thresholdForOptimizeAfterWarmUp
+
+        Unreviewed.
+
+        This adds back the assertion removed in r201845.
+        Making those threshold equal is completely perf neutral
+        (on Haswell rMBP with 20 runs).
+
+        * runtime/Options.cpp:
+        (JSC::Options::initialize):
+        * runtime/Options.h:
+
 2016-06-08  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/JavaScriptCore/runtime/Options.cpp

@@ -450 +450 @@
             // Do range checks where needed and make corrections to the options:
             ASSERT(Options::thresholdForOptimizeAfterLongWarmUp() >= Options::thresholdForOptimizeAfterWarmUp());
+            ASSERT(Options::thresholdForOptimizeAfterWarmUp() >= Options::thresholdForOptimizeSoon());
             ASSERT(Options::thresholdForOptimizeAfterWarmUp() >= 0);
 

trunk/Source/JavaScriptCore/runtime/Options.h

@@ -259 +259 @@
     v(int32, thresholdForOptimizeAfterWarmUp, 511, Normal, nullptr) \
     v(int32, thresholdForOptimizeAfterLongWarmUp, 885, Normal, nullptr) \
-    v(int32, thresholdForOptimizeSoon, 853, Normal, nullptr) \
+    v(int32, thresholdForOptimizeSoon, 511, Normal, nullptr) \
     v(int32, executionCounterIncrementForLoop, 2, Normal, nullptr) \
     v(int32, executionCounterIncrementForEntry, 28, Normal, nullptr) \