Changeset 201859 in webkit

Timestamp:

Jun 9, 2016 5:07:38 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

[Threaded Compositor] Remove ThreadedCompositor::setNeedsDisplay()
​https://bugs.webkit.org/show_bug.cgi?id=158523

Reviewed by Michael Catanzaro.

ThreadedCompositor::setNeedsDisplay() is always called from the main thread and schedules a task to the
compositing thread to schedule an immediate update. But RunLoop::Timer is thread-safe so we don't really need to
schedule a task to the update the timer in the compositing thread, we can do that directly in the main
thread. And that's exactly what scheduleDisplayImmediately() does, so we can use it instead of setNeedsDisplay().

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::setNeedsDisplay(): Deleted.
(WebKit::ThreadedCompositor::updateSceneState):

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp (modified) (2 diffs)
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-06-09  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [Threaded Compositor] Remove ThreadedCompositor::setNeedsDisplay()
+        https://bugs.webkit.org/show_bug.cgi?id=158523
+
+        Reviewed by Michael Catanzaro.
+
+        ThreadedCompositor::setNeedsDisplay() is always called from the main thread and schedules a task to the
+        compositing thread to schedule an immediate update. But RunLoop::Timer is thread-safe so we don't really need to
+        schedule a task to the update the timer in the compositing thread, we can do that directly in the main
+        thread. And that's exactly what scheduleDisplayImmediately() does, so we can use it instead of setNeedsDisplay().
+
+        * Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
+        (WebKit::ThreadedCompositor::setNeedsDisplay(): Deleted.
+        (WebKit::ThreadedCompositor::updateSceneState):
+        * Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
+
 2016-06-08  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp

@@ -62 +62 @@
 }
 
-void ThreadedCompositor::setNeedsDisplay()
-{
-    RefPtr<ThreadedCompositor> protector(this);
-    callOnCompositingThread([protector] {
-        protector->scheduleDisplayImmediately();
-    });
-}
-
 void ThreadedCompositor::setNativeSurfaceHandleForCompositing(uint64_t handle)
 {
@@ -222 +214 @@
     });
 
-    setNeedsDisplay();
+    scheduleDisplayImmediately();
 }
 

trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h

@@ -65 +65 @@
     virtual ~ThreadedCompositor();
 
-    void setNeedsDisplay();
-
     void setNativeSurfaceHandleForCompositing(uint64_t);
     void setDeviceScaleFactor(float);