Changeset 20186 in webkit

Timestamp:

Mar 14, 2007 4:37:21 AM (17 years ago)

Author:

antti

Message:

LayoutTests:

Reviewed by Mitz.

Test case for <rdar://problem/5058774>
REGRESSION: In Mail, caret appears oversized when typing in a To Do note

• editing/style/highlight-expected.checksum: Added.
• editing/style/highlight-expected.png: Added.
• editing/style/highlight-expected.txt: Added.
• editing/style/highlight.html: Added.

WebCore:

Reviewed by Mitz.

Fix <rdar://problem/5058774>
REGRESSION: In Mail, caret appears oversized when typing in a To Do note

Horizontal and vertical were switched. Was regression from
​http://trac.webkit.org/projects/webkit/changeset/20103

• rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/style/highlight-expected.checksum (added)
• LayoutTests/editing/style/highlight-expected.png (added)
• LayoutTests/editing/style/highlight-expected.txt (added)
• LayoutTests/editing/style/highlight.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RootInlineBox.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-03-14  Antti Koivisto  <antti@apple.com>
+
+        Reviewed by Mitz.
+        
+        Test case for <rdar://problem/5058774>
+        REGRESSION: In Mail, caret appears oversized when typing in a To Do note
+
+        * editing/style/highlight-expected.checksum: Added.
+        * editing/style/highlight-expected.png: Added.
+        * editing/style/highlight-expected.txt: Added.
+        * editing/style/highlight.html: Added.
+
 2007-03-13  Justin Garcia  <justin.garcia@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-03-14  Antti Koivisto  <antti@apple.com>
+
+        Reviewed by Mitz.
+        
+        Fix <rdar://problem/5058774>
+        REGRESSION: In Mail, caret appears oversized when typing in a To Do note
+        
+        Horizontal and vertical were switched. Was regression from
+        http://trac.webkit.org/projects/webkit/changeset/20103
+
+        * rendering/RootInlineBox.cpp:
+        (WebCore::RootInlineBox::addHighlightOverflow):
+
 2007-03-14  David Hyatt  <hyatt@apple.com>
 

trunk/WebCore/rendering/RootInlineBox.cpp

@@ -141 +141 @@
     FloatRect rootRect(0, selectionTop(), width(), selectionHeight());
     IntRect inflatedRect = enclosingIntRect(object()->document()->frame()->customHighlightLineRect(object()->style()->highlight(), rootRect, object()->node()));
-    setVerticalOverflowPositions(min(leftOverflow(), inflatedRect.x()), max(rightOverflow(), inflatedRect.right()));
-    setHorizontalOverflowPositions(min(topOverflow(), inflatedRect.y()), max(bottomOverflow(), inflatedRect.bottom()));
+    setHorizontalOverflowPositions(min(leftOverflow(), inflatedRect.x()), max(rightOverflow(), inflatedRect.right()));
+    setVerticalOverflowPositions(min(topOverflow(), inflatedRect.y()), max(bottomOverflow(), inflatedRect.bottom()));
 }