Changeset 20194 in webkit

Timestamp:

Mar 14, 2007 1:38:28 PM (17 years ago)

Author:

antti

Message:

Reviewed by Geoff.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=13060
REGRESSION: Repro ASSERT failure in Cache::adjustSize running layout tests
<rdar://5060208>

Script evaluation may have dereffed the CachedScript object already, causing double deref and
eventually m_liveResourcesSize underflow.

• html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::notifyFinished):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLScriptElement.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-03-14  Antti Koivisto  <antti@apple.com>
+
+        Reviewed by Geoff.
+
+        Fix http://bugs.webkit.org/show_bug.cgi?id=13060
+        REGRESSION: Repro ASSERT failure in Cache::adjustSize running layout tests
+        <rdar://5060208>
+        
+        Script evaluation may have dereffed the CachedScript object already, causing double deref and
+        eventually m_liveResourcesSize underflow.
+
+        * html/HTMLScriptElement.cpp:
+        (WebCore::HTMLScriptElement::notifyFinished):
+
 2007-03-14  Adele Peterson  <adele@apple.com>
 

trunk/WebCore/html/HTMLScriptElement.cpp

@@ -156 +156 @@
     }
 
-    cs->deref(this);
-    m_cachedScript = 0;
+    // script evaluation may have dereffed it already
+    if (m_cachedScript) {
+        m_cachedScript->deref(this);
+        m_cachedScript = 0;
+    }
 }