Changeset 201981 in webkit

Timestamp:

Jun 11, 2016 4:44:50 PM (8 years ago)

Author:

ap@apple.com

Message:

Unreviewed leak fix after r201863.

• DumpRenderTree/mac/DumpRenderTree.mm:

(dumpFramesAsText):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/mac/DumpRenderTree.mm (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-06-11  Alexey Proskuryakov  <ap@apple.com>
+
+        Unreviewed leak fix after r201863.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (dumpFramesAsText):
+
 2016-06-11  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm

@@ -63 +63 @@
 #import <WebKit/DOMExtensions.h>
 #import <WebKit/DOMRange.h>
+#import <WebKit/WKRetainPtr.h>
 #import <WebKit/WKString.h>
 #import <WebKit/WKStringCF.h>
@@ -1532 +1533 @@
     // a CFString via fromUTF8WithLatin1Fallback().createCFString() which can be appended to
     // the result without any conversion.
-    WKStringRef stringRef = WKStringCreateWithCFString((CFStringRef)innerText);
-    size_t bufferSize = WKStringGetMaximumUTF8CStringSize(stringRef);
+    WKRetainPtr<WKStringRef> stringRef(AdoptWK, WKStringCreateWithCFString((CFStringRef)innerText));
+    size_t bufferSize = WKStringGetMaximumUTF8CStringSize(stringRef.get());
     auto buffer = std::make_unique<char[]>(bufferSize);
-    size_t stringLength = WKStringGetUTF8CStringNonStrict(stringRef, buffer.get(), bufferSize);
+    size_t stringLength = WKStringGetUTF8CStringNonStrict(stringRef.get(), buffer.get(), bufferSize);
     [result appendFormat:@"%@\n", String::fromUTF8WithLatin1Fallback(buffer.get(), stringLength - 1).createCFString().get()];