Changeset 202037 in webkit

Timestamp:

Jun 14, 2016 12:48:54 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

[Threaded Compositor] Flickering and rendering artifacts when resizing the web view
​https://bugs.webkit.org/show_bug.cgi?id=154070

Reviewed by Žan Doberšek.

Resizing the web view is expected to be a sync operation, the UI process creates a new backing store state ID,
sends UpdateBackingStoreState message with the flag RespondImmediately to the web process and waits up to 500ms
for the reply (DidUpdateBackingStoreState message). When using the threaded compositor, we schedule a task in
the compositing thread to update the viewport size, and return immediately, so that we reply to the UI process
before the compositing thread has actually updated its size. There's a moment in which sizes are out of sync
causing the flickering and rendering artifacts, the UI process continues rendering at the new size, while the
web process is still rendering at the previous size. We can prevent this from happening just by making the
resize task synchronous in the threaded compositor.

• Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:

(WebKit::CompositingRunLoop::performTaskSync): Add sync version of performTask().

• Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::didChangeViewportSize): Use performTaskSync().

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp (modified) (2 diffs)
• Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h (modified) (2 diffs)
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [Threaded Compositor] Flickering and rendering artifacts when resizing the web view
+        https://bugs.webkit.org/show_bug.cgi?id=154070
+
+        Reviewed by Žan Doberšek.
+
+        Resizing the web view is expected to be a sync operation, the UI process creates a new backing store state ID,
+        sends UpdateBackingStoreState message with the flag RespondImmediately to the web process and waits up to 500ms
+        for the reply (DidUpdateBackingStoreState message). When using the threaded compositor, we schedule a task in
+        the compositing thread to update the viewport size, and return immediately, so that we reply to the UI process
+        before the compositing thread has actually updated its size. There's a moment in which sizes are out of sync
+        causing the flickering and rendering artifacts, the UI process continues rendering at the new size, while the
+        web process is still rendering at the previous size. We can prevent this from happening just by making the
+        resize task synchronous in the threaded compositor.
+
+        * Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:
+        (WebKit::CompositingRunLoop::performTaskSync): Add sync version of performTask().
+        * Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:
+        * Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
+        (WebKit::ThreadedCompositor::didChangeViewportSize): Use performTaskSync().
+
 2016-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp

@@ -38 +38 @@
     , m_updateTimer(m_runLoop, this, &CompositingRunLoop::updateTimerFired)
     , m_updateFunction(WTFMove(updateFunction))
-    , m_lastUpdateTime(0)
 {
 }
@@ -46 +45 @@
     ASSERT(isMainThread());
     m_runLoop.dispatch(WTFMove(function));
+}
+
+void CompositingRunLoop::performTaskSync(std::function<void ()>&& function)
+{
+    ASSERT(isMainThread());
+    LockHolder locker(m_dispatchSyncConditionMutex);
+    m_runLoop.dispatch([this, function = WTFMove(function)] {
+        LockHolder locker(m_dispatchSyncConditionMutex);
+        function();
+        m_dispatchSyncCondition.notifyOne();
+    });
+    m_dispatchSyncCondition.wait(m_dispatchSyncConditionMutex);
 }
 

trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h

@@ -48 +48 @@
 
     void performTask(std::function<void ()>&&);
+    void performTaskSync(std::function<void ()>&&);
 
     void setUpdateTimer(UpdateTiming timing = Immediate);
@@ -60 +61 @@
     RunLoop::Timer<CompositingRunLoop> m_updateTimer;
     std::function<void ()> m_updateFunction;
+    Lock m_dispatchSyncConditionMutex;
+    Condition m_dispatchSyncCondition;
 
-    double m_lastUpdateTime;
+    double m_lastUpdateTime { 0 };
 };
 

trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp

@@ -83 +83 @@
 {
     RefPtr<ThreadedCompositor> protector(this);
-    m_compositingRunLoop->performTask([protector, size] {
+    m_compositingRunLoop->performTaskSync([protector, size] {
         protector->viewportController()->didChangeViewportSize(size);
     });