Changeset 202043 in webkit

Timestamp:

Jun 14, 2016 8:13:20 AM (8 years ago)

Author:

adam.bergkvist@ericsson.com

Message:

WebRTC: Add media setup test where media is set up in one direction at a time
​https://bugs.webkit.org/show_bug.cgi?id=158691

Reviewed by Eric Carlson.

Source/WebCore:

Add test for setting up media in one direction at a time. This requires a change in sdp.js
to allow an SDP that doesn't contain a stream id or track id (representing
a track being sent). In this test, the first answer doesn't contain any sending media.

Test: fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html

• Modules/mediastream/sdp.js:

LayoutTests:

Test setting up media in one direction at a time. This is achieved by first negotiating
media in one direction. In a second step, an updated offer is sent to add bi-directional
media.

• fast/mediastream/RTCPeerConnection-media-setup-two-dialogs-expected.txt: Added.
• fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html: Added.
• platform/mac/TestExpectations:

The mac port is not building with WEB_RTC yet.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-two-dialogs-expected.txt (added)
• LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html (added)
• LayoutTests/platform/mac/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/mediastream/sdp.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-06-14  Adam Bergkvist  <adam.bergkvist@ericsson.com>
+
+        WebRTC: Add media setup test where media is set up in one direction at a time
+        https://bugs.webkit.org/show_bug.cgi?id=158691
+
+        Reviewed by Eric Carlson.
+
+        Test setting up media in one direction at a time. This is achieved by first negotiating
+        media in one direction. In a second step, an updated offer is sent to add bi-directional
+        media.
+
+        * fast/mediastream/RTCPeerConnection-media-setup-two-dialogs-expected.txt: Added.
+        * fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html: Added.
+        * platform/mac/TestExpectations:
+        The mac port is not building with WEB_RTC yet.
+
 2016-06-13  Adam Bergkvist  <adam.bergkvist@ericsson.com>
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -197 +197 @@
 fast/mediastream/RTCPeerConnection-inspect-answer.html
 fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html
+fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html
 
 # Asserts in debug.

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-14  Adam Bergkvist  <adam.bergkvist@ericsson.com>
+
+        WebRTC: Add media setup test where media is set up in one direction at a time
+        https://bugs.webkit.org/show_bug.cgi?id=158691
+
+        Reviewed by Eric Carlson.
+
+        Add test for setting up media in one direction at a time. This requires a change in sdp.js
+        to allow an SDP that doesn't contain a stream id or track id (representing
+        a track being sent). In this test, the first answer doesn't contain any sending media.
+
+        Test: fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html
+
+        * Modules/mediastream/sdp.js:
+
 2016-06-14  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/Modules/mediastream/sdp.js

@@ -539 +539 @@
     var expectedProperties = {
         "session": [ "version", "originator", "sessionName", "startTime", "stopTime" ],
-        "mline": [ "type", "port", "protocol", "mode", "payloads", "rtcp", "mediaStreamId",
-            "mediaStreamTrackId", "dtls", "ssrcs", "cname", "ice" ],
+        "mline": [ "type", "port", "protocol", "mode", "payloads", "rtcp", "dtls", "ice" ],
         "mlineSubObjects": {
             "rtcp": [ "mux" ],