Changeset 202195 in webkit


Ignore:
Timestamp:
Jun 17, 2016 8:29:49 PM (8 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r202068, r202115, and r202128.
https://bugs.webkit.org/show_bug.cgi?id=158896

The new test is very unstable, timing out frequently
(Requested by ap on #webkit).

Reverted changesets:

"decompose4 return value is unchecked, leading to potentially
uninitialized data."
https://bugs.webkit.org/show_bug.cgi?id=158761
http://trac.webkit.org/changeset/202068

"[mac] LayoutTest transforms/undecomposable.html is a flaky
timeout"
https://bugs.webkit.org/show_bug.cgi?id=158816
http://trac.webkit.org/changeset/202115

"[mac] LayoutTest transforms/undecomposable.html is a flaky
timeout"
https://bugs.webkit.org/show_bug.cgi?id=158816
http://trac.webkit.org/changeset/202128

Location:
trunk
Files:
2 deleted
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r202194 r202195  
     12016-06-17  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r202068, r202115, and r202128.
     4        https://bugs.webkit.org/show_bug.cgi?id=158896
     5
     6        The new test is very unstable, timing out frequently
     7        (Requested by ap on #webkit).
     8
     9        Reverted changesets:
     10
     11        "decompose4 return value is unchecked, leading to potentially
     12        uninitialized data."
     13        https://bugs.webkit.org/show_bug.cgi?id=158761
     14        http://trac.webkit.org/changeset/202068
     15
     16        "[mac] LayoutTest transforms/undecomposable.html is a flaky
     17        timeout"
     18        https://bugs.webkit.org/show_bug.cgi?id=158816
     19        http://trac.webkit.org/changeset/202115
     20
     21        "[mac] LayoutTest transforms/undecomposable.html is a flaky
     22        timeout"
     23        https://bugs.webkit.org/show_bug.cgi?id=158816
     24        http://trac.webkit.org/changeset/202128
     25
    1262016-06-17  Chris Fleizach  <cfleizach@apple.com>
    227
  • trunk/Source/WebCore/ChangeLog

    r202194 r202195  
     12016-06-17  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r202068, r202115, and r202128.
     4        https://bugs.webkit.org/show_bug.cgi?id=158896
     5
     6        The new test is very unstable, timing out frequently
     7        (Requested by ap on #webkit).
     8
     9        Reverted changesets:
     10
     11        "decompose4 return value is unchecked, leading to potentially
     12        uninitialized data."
     13        https://bugs.webkit.org/show_bug.cgi?id=158761
     14        http://trac.webkit.org/changeset/202068
     15
     16        "[mac] LayoutTest transforms/undecomposable.html is a flaky
     17        timeout"
     18        https://bugs.webkit.org/show_bug.cgi?id=158816
     19        http://trac.webkit.org/changeset/202115
     20
     21        "[mac] LayoutTest transforms/undecomposable.html is a flaky
     22        timeout"
     23        https://bugs.webkit.org/show_bug.cgi?id=158816
     24        http://trac.webkit.org/changeset/202128
     25
    1262016-06-17  Chris Fleizach  <cfleizach@apple.com>
    227
  • trunk/Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.cpp

    r202068 r202195  
    6161    toT.blend(fromT, progress);
    6262    TransformationMatrix::Decomposed4Type decomp;
    63     if (toT.decompose4(decomp)) {
    64         if (decomp.perspectiveZ) {
    65             double val = -1.0 / decomp.perspectiveZ;
    66             return PerspectiveTransformOperation::create(Length(clampToPositiveInteger(val), Fixed));
    67         }
     63    toT.decompose4(decomp);
     64
     65    if (decomp.perspectiveZ) {
     66        double val = -1.0 / decomp.perspectiveZ;
     67        return PerspectiveTransformOperation::create(Length(clampToPositiveInteger(val), Fixed));
    6868    }
    6969    return PerspectiveTransformOperation::create(Length(0, Fixed));
  • trunk/Source/WebCore/platform/graphics/transforms/RotateTransformOperation.cpp

    r202068 r202195  
    7979    // Extract the result as a quaternion
    8080    TransformationMatrix::Decomposed4Type decomp;
    81     if (!toT.decompose4(decomp))
    82         return RotateTransformOperation::create(m_x, m_y, m_z, m_angle - m_angle * progress, m_type);;
     81    toT.decompose4(decomp);
    8382   
    8483    // Convert that to Axis/Angle form
  • trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp

    r202068 r202195  
    366366
    367367    int i, j;
    368     for (i = 0; i < 4; i++) {
     368    for (i = 0; i < 4; i++)
    369369        for (j = 0; j < 4; j++)
    370370            localMatrix[i][j] /= localMatrix[3][3];
    371     }
    372371
    373372    // perspectiveMatrix is used to solve for perspective, but it also provides
     
    15431542    Decomposed4Type fromDecomp;
    15441543    Decomposed4Type toDecomp;
    1545     if (!from.decompose4(fromDecomp))
    1546         return;
    1547     if (!decompose4(toDecomp))
    1548         return;
     1544    from.decompose4(fromDecomp);
     1545    decompose4(toDecomp);
    15491546
    15501547    blendFloat(fromDecomp.scaleX, toDecomp.scaleX, progress);
  • trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h

    r202068 r202195  
    273273
    274274    struct Decomposed4Type {
    275         double scaleX { 1 };
    276         double scaleY { 1 };
    277         double scaleZ { 1 };
    278         double skewXY { 0 };
    279         double skewXZ { 0 };
    280         double skewYZ { 0 };
    281         double quaternionX { 0 };
    282         double quaternionY { 0 };
    283         double quaternionZ { 0 };
    284         double quaternionW { 0 };
    285         double translateX { 0 };
    286         double translateY { 0 };
    287         double translateZ { 0 };
    288         double perspectiveX { 0 };
    289         double perspectiveY { 0 };
    290         double perspectiveZ { 0 };
    291         double perspectiveW { 1 };
     275        double scaleX, scaleY, scaleZ;
     276        double skewXY, skewXZ, skewYZ;
     277        double quaternionX, quaternionY, quaternionZ, quaternionW;
     278        double translateX, translateY, translateZ;
     279        double perspectiveX, perspectiveY, perspectiveZ, perspectiveW;
    292280
    293281        bool operator==(const Decomposed4Type& other) const
Note: See TracChangeset for help on using the changeset viewer.