Changeset 202238 in webkit

Timestamp:

Jun 20, 2016, 1:38:41 PM (9 years ago)

Author:

eric.carlson@apple.com

Message:

Crash in PlatformMediaSession::clientWillPausePlayback
​https://bugs.webkit.org/show_bug.cgi?id=158953
<rdar://problem/26121125>

Reviewed by Jer Noble.

No new tests, I have not been able to reproduce this in a test.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::stop): Ref the element before calling stopWithoutDestroyingMediaPlayer

because updatePlaybackControlsManager can release the last reference and cause the
destructor to be called.

(WebCore::HTMLMediaElement::suspend): Ditto.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLMediaElement.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-20  Eric Carlson  <eric.carlson@apple.com>
+
+        Crash in PlatformMediaSession::clientWillPausePlayback
+        https://bugs.webkit.org/show_bug.cgi?id=158953
+        <rdar://problem/26121125>
+
+        Reviewed by Jer Noble.
+
+        No new tests, I have not been able to reproduce this in a test.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::stop): Ref the element before calling stopWithoutDestroyingMediaPlayer
+          because updatePlaybackControlsManager can release the last reference and cause the
+          destructor to be called.
+        (WebCore::HTMLMediaElement::suspend): Ditto.
+
 2016-06-20  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -5093 +5093 @@
     LOG(Media, "HTMLMediaElement::stop(%p)", this);
 
+    Ref<HTMLMediaElement> protectedThis(*this);
     stopWithoutDestroyingMediaPlayer();
 
@@ -5110 +5111 @@
 {
     LOG(Media, "HTMLMediaElement::suspend(%p)", this);
+    Ref<HTMLMediaElement> protectedThis(*this);
 
     switch (why)