Changeset 202293 in webkit

Timestamp:

Jun 21, 2016 1:58:27 PM (8 years ago)

Author:

adam.bergkvist@ericsson.com

Message:

WebRTC: Remove unused MediaEndpointClient::gotRemoteSource function
​https://bugs.webkit.org/show_bug.cgi?id=158986

Reviewed by Eric Carlson.

Remote sources are explicitly created with MediaEndpoint::createMutedRemoteSource so the
MediaEndpointClient::gotRemoteSource can be removed.

No change in behavior.

• Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::gotRemoteSource): Deleted.

• Modules/mediastream/MediaEndpointPeerConnection.h:
• platform/mediastream/MediaEndpoint.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediastream/MediaEndpointPeerConnection.cpp (modified) (1 diff)
• Modules/mediastream/MediaEndpointPeerConnection.h (modified) (1 diff)
• platform/mediastream/MediaEndpoint.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-21  Adam Bergkvist  <adam.bergkvist@ericsson.com>
+
+        WebRTC: Remove unused MediaEndpointClient::gotRemoteSource function
+        https://bugs.webkit.org/show_bug.cgi?id=158986
+
+        Reviewed by Eric Carlson.
+
+        Remote sources are explicitly created with MediaEndpoint::createMutedRemoteSource so the
+        MediaEndpointClient::gotRemoteSource can be removed.
+
+        No change in behavior.
+
+        * Modules/mediastream/MediaEndpointPeerConnection.cpp:
+        (WebCore::MediaEndpointPeerConnection::gotRemoteSource): Deleted.
+        * Modules/mediastream/MediaEndpointPeerConnection.h:
+        * platform/mediastream/MediaEndpoint.h:
+
 2016-06-20  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp

@@ -807 +807 @@
 }
 
-void MediaEndpointPeerConnection::gotRemoteSource(unsigned mdescIndex, RefPtr<RealtimeMediaSource>&& source)
-{
-    ASSERT(isMainThread());
-
-    UNUSED_PARAM(mdescIndex);
-    UNUSED_PARAM(source);
-
-    notImplemented();
-}
-
 } // namespace WebCore
 

trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h

@@ -108 +108 @@
     void gotIceCandidate(unsigned mdescIndex, RefPtr<IceCandidate>&&) override;
     void doneGatheringCandidates(unsigned mdescIndex) override;
-    void gotRemoteSource(unsigned mdescIndex, RefPtr<RealtimeMediaSource>&&) override;
 
     PeerConnectionBackendClient* m_client;

trunk/Source/WebCore/platform/mediastream/MediaEndpoint.h

@@ -51 +51 @@
     virtual void gotIceCandidate(unsigned mdescIndex, RefPtr<IceCandidate>&&) = 0;
     virtual void doneGatheringCandidates(unsigned mdescIndex) = 0;
-    virtual void gotRemoteSource(unsigned mdescIndex, RefPtr<RealtimeMediaSource>&&) = 0;
 
     virtual ~MediaEndpointClient() { }