Changeset 202338 in webkit

Timestamp:

Jun 22, 2016 11:14:10 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=155760

Patch by Youenn Fablet <​youennf@gmail.com> on 2016-06-22
Reviewed by Alexey Proskuryakov.

Making test more predictable.
Upstreamed to w3c repository as ​https://github.com/w3c/web-platform-tests/pull/3203.

• web-platform-tests/streams/readable-streams/general.js:

(promise_test):

Location:

trunk/LayoutTests/imported/w3c

Files:

• ChangeLog (modified) (1 diff)
• web-platform-tests/streams/readable-streams/general.js (modified) (2 diffs)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2016-06-22  Youenn Fablet  <youennf@gmail.com>
+
+        imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=155760
+
+        Reviewed by Alexey Proskuryakov.
+
+        Making test more predictable.
+        Upstreamed to w3c repository as https://github.com/w3c/web-platform-tests/pull/3203.
+
+        * web-platform-tests/streams/readable-streams/general.js:
+        (promise_test):
+
 2016-06-21  Youenn Fablet  <youennf@gmail.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.js

@@ -294 +294 @@
 
   let pullCount = 0;
-
-  const rs = new ReadableStream({
+  const startPromise = Promise.resolve();
+
+  const rs = new ReadableStream({
+    start() {
+      return startPromise;
+    },
     pull(c) {
       // Don't enqueue immediately after start. We want the stream to be empty when we call .read() on it.
@@ -305 +309 @@
   });
 
-  // WEBKIT modification: delay(1) replaced by delay(10) to ensure that pull promise is resolved before calling below thened code.
-  return delay(10).then(() => {
+  return startPromise.then(() => {
     assert_equals(pullCount, 1, 'pull should be called once start finishes');
-
+  }).then(() => {
     const reader = rs.getReader();
     const read = reader.read();