Changeset 202426 in webkit

Timestamp:

Jun 24, 2016 10:13:38 AM (8 years ago)

Author:

Chris Dumez

Message:

[WK2] PageConfiguration.m_relatedPage keeps WebPageProxy alive after its WebView has been destroyed
​https://bugs.webkit.org/show_bug.cgi?id=159080
<rdar://problem/26982642>

Reviewed by Anders Carlsson.

PageConfiguration.m_relatedPage keeps WebPageProxy alive after its WebView has been destroyed.
This leads to WebPageProxy object leaks when the client keeps chaining related views.

In this patch, we null our the PageConfiguration's relatedPage in WebPageProxy::close()
to break the chain and make sure we only keep alive 1 relatedPage rather than a chain of
them.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-06-24  Chris Dumez  <cdumez@apple.com>
+
+        [WK2] PageConfiguration.m_relatedPage keeps WebPageProxy alive after its WebView has been destroyed
+        https://bugs.webkit.org/show_bug.cgi?id=159080
+        <rdar://problem/26982642>
+
+        Reviewed by Anders Carlsson.
+
+        PageConfiguration.m_relatedPage keeps WebPageProxy alive after its WebView has been destroyed.
+        This leads to WebPageProxy object leaks when the client keeps chaining related views.
+
+        In this patch, we null our the PageConfiguration's relatedPage in WebPageProxy::close()
+        to break the chain and make sure we only keep alive 1 relatedPage rather than a chain of
+        them.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::close):
+
 2016-06-24  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -871 +871 @@
     m_process->processPool().supplement<WebNotificationManagerProxy>()->clearNotifications(this);
 
+    // Null out related WebPageProxy to avoid leaks.
+    m_configuration->setRelatedPage(nullptr);
+
 #if PLATFORM(IOS)
     // Make sure we don't hold a process assertion after getting closed.