Changeset 202472 in webkit

Timestamp:

Jun 26, 2016 9:25:49 AM (8 years ago)

Author:

Chris Dumez

Message:

Regression(r202262): Infinite loop under searchForLinkRemovingExistingDDLinks()
​https://bugs.webkit.org/show_bug.cgi?id=159122
<rdar://problem/27014649>

Reviewed by Ryosuke Niwa.

Infinite loop under searchForLinkRemovingExistingDDLinks() because the
value returned by NodeTraversal::next() was ignored and the node iterator
was never updated.

• editing/cocoa/DataDetection.mm:

(WebCore::searchForLinkRemovingExistingDDLinks):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/cocoa/DataDetection.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-26  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r202262): Infinite loop under searchForLinkRemovingExistingDDLinks()
+        https://bugs.webkit.org/show_bug.cgi?id=159122
+        <rdar://problem/27014649>
+
+        Reviewed by Ryosuke Niwa.
+
+        Infinite loop under searchForLinkRemovingExistingDDLinks() because the
+        value returned by NodeTraversal::next() was ignored and the node iterator
+        was never updated.
+
+        * editing/cocoa/DataDetection.mm:
+        (WebCore::searchForLinkRemovingExistingDDLinks):
+
 2016-06-25  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/WebCore/editing/cocoa/DataDetection.mm

@@ -274 +274 @@
 {
     didModifyDOM = false;
-    for (Node* node = &startNode; node; NodeTraversal::next(*node)) {
+    for (Node* node = &startNode; node; node = NodeTraversal::next(*node, &startNode)) {
         if (is<HTMLAnchorElement>(*node)) {
             auto& anchor = downcast<HTMLAnchorElement>(*node);