Changeset 202488 in webkit

Timestamp:

Jun 27, 2016 10:33:38 AM (8 years ago)

Author:

fred.wang@free.fr

Message:

Small refactoring MathMLInlineContainerElement::createElementRenderer
​https://bugs.webkit.org/show_bug.cgi?id=159131

Reviewed by Brent Fulgham.

Many of the MathML renderer classes have been merged during the MathML refactoring. We
simplify how instances are created in MathMLInlineContainerElement::createElementRenderer
by removing duplicate createRenderer calls.

No new tests, behavior unchanged.

• mathml/MathMLInlineContainerElement.cpp:

(WebCore::MathMLInlineContainerElement::createElementRenderer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• mathml/MathMLInlineContainerElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-27  Frederic Wang  <fred.wang@free.fr>
+
+        Small refactoring MathMLInlineContainerElement::createElementRenderer
+        https://bugs.webkit.org/show_bug.cgi?id=159131
+
+        Reviewed by Brent Fulgham.
+
+        Many of the MathML renderer classes have been merged during the MathML refactoring. We
+        simplify how instances are created in MathMLInlineContainerElement::createElementRenderer
+        by removing duplicate createRenderer calls.
+
+        No new tests, behavior unchanged.
+
+        * mathml/MathMLInlineContainerElement.cpp:
+        (WebCore::MathMLInlineContainerElement::createElementRenderer):
+
 2016-06-27  Miguel Gomez  <magomez@igalia.com>
 

trunk/Source/WebCore/mathml/MathMLInlineContainerElement.cpp

@@ -66 +66 @@
 RenderPtr<RenderElement> MathMLInlineContainerElement::createElementRenderer(RenderStyle&& style, const RenderTreePosition&)
 {
-    if (hasTagName(annotation_xmlTag))
+    if (hasTagName(annotation_xmlTag) || hasTagName(merrorTag) || hasTagName(mphantomTag) || hasTagName(mrowTag) || hasTagName(mstyleTag))
         return createRenderer<RenderMathMLRow>(*this, WTFMove(style));
-    if (hasTagName(merrorTag) || hasTagName(mphantomTag) || hasTagName(mrowTag) || hasTagName(mstyleTag))
-        return createRenderer<RenderMathMLRow>(*this, WTFMove(style));
-    if (hasTagName(msubTag))
+    if (hasTagName(msubTag) || hasTagName(msupTag) || hasTagName(msubsupTag) || hasTagName(mmultiscriptsTag))
         return createRenderer<RenderMathMLScripts>(*this, WTFMove(style));
-    if (hasTagName(msupTag))
-        return createRenderer<RenderMathMLScripts>(*this, WTFMove(style));
-    if (hasTagName(msubsupTag))
-        return createRenderer<RenderMathMLScripts>(*this, WTFMove(style));
-    if (hasTagName(mmultiscriptsTag))
-        return createRenderer<RenderMathMLScripts>(*this, WTFMove(style));
-    if (hasTagName(moverTag))
-        return createRenderer<RenderMathMLUnderOver>(*this, WTFMove(style));
-    if (hasTagName(munderTag))
-        return createRenderer<RenderMathMLUnderOver>(*this, WTFMove(style));
-    if (hasTagName(munderoverTag))
+    if (hasTagName(moverTag) || hasTagName(munderTag) || hasTagName(munderoverTag))
         return createRenderer<RenderMathMLUnderOver>(*this, WTFMove(style));
     if (hasTagName(mfracTag))