Changeset 202515 in webkit


Ignore:
Timestamp:
Jun 27, 2016 2:50:46 PM (8 years ago)
Author:
BJ Burg
Message:

Web Inspector: CRASH in backend at Inspector::HeapFrontendDispatcher::garbageCollected + 552 when closing frontend/inspected page
https://bugs.webkit.org/show_bug.cgi?id=159075
<rdar://problem/26094341>

Reviewed by Filip Pizlo.

This change caused JSC stress tests to all hit an assertion in RunLoop.
We should use RunLoop::current() to create the RunLoop::Timer since JSC-only
clients like testapi and jsc don't ever call initializeMainRunLoop().

  • inspector/agents/InspectorHeapAgent.cpp:

(Inspector::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):

Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r202512 r202515  
     12016-06-27  Brian Burg  <bburg@apple.com>
     2
     3        Web Inspector: CRASH in backend at Inspector::HeapFrontendDispatcher::garbageCollected + 552 when closing frontend/inspected page
     4        https://bugs.webkit.org/show_bug.cgi?id=159075
     5        <rdar://problem/26094341>
     6
     7        Reviewed by Filip Pizlo.
     8
     9        This change caused JSC stress tests to all hit an assertion in RunLoop.
     10        We should use RunLoop::current() to create the RunLoop::Timer since JSC-only
     11        clients like testapi and jsc don't ever call initializeMainRunLoop().
     12
     13        * inspector/agents/InspectorHeapAgent.cpp:
     14        (Inspector::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):
     15
    1162016-06-27  Filip Pizlo  <fpizlo@apple.com>
    217
  • trunk/Source/JavaScriptCore/inspector/agents/InspectorHeapAgent.cpp

    r202492 r202515  
    6262SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask(HeapFrontendDispatcher& frontendDispatcher)
    6363    : m_frontendDispatcher(frontendDispatcher)
    64     , m_timer(RunLoop::main(), this, &SendGarbageCollectionEventsTask::timerFired)
     64    , m_timer(RunLoop::current(), this, &SendGarbageCollectionEventsTask::timerFired)
    6565{
    6666}
Note: See TracChangeset for help on using the changeset viewer.