Changeset 202556 in webkit

Timestamp:

Jun 28, 2016, 3:20:59 AM (9 years ago)

Author:

Philippe Normand

Message:

[GStreamer] improved duration query support in the HTTP source element
​https://bugs.webkit.org/show_bug.cgi?id=159204

Reviewed by Carlos Garcia Campos.

When we have the Content-Length value it is possible to infer the TIME
duration in most cases by performing a convert query in the downstream
elements. This is especially useful when the duration query wasn't
managed by the sinks and thus reached the source element.

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcQueryWithParent):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-28  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer] improved duration query support in the HTTP source element
+        https://bugs.webkit.org/show_bug.cgi?id=159204
+
+        Reviewed by Carlos Garcia Campos.
+
+        When we have the Content-Length value it is possible to infer the TIME
+        duration in most cases by performing a convert query in the downstream
+        elements. This is especially useful when the duration query wasn't
+        managed by the sinks and thus reached the source element.
+
+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+        (webKitWebSrcQueryWithParent):
+
 2016-06-28  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

@@ -676 +676 @@
             gst_query_set_duration(query, format, src->priv->size);
             result = TRUE;
+        } else if (format == GST_FORMAT_TIME) {
+            gint64 duration = -1;
+            GRefPtr<GstPad> target = adoptGRef(gst_ghost_pad_get_target(GST_GHOST_PAD_CAST(pad)));
+            GRefPtr<GstPad> peer = adoptGRef(gst_pad_get_peer(target.get()));
+            result = gst_pad_query_convert(peer.get(), GST_FORMAT_BYTES, src->priv->size, format, &duration);
+            if (result)
+                gst_query_set_duration(query, format, duration);
         }
         break;