Changeset 202562 in webkit

Timestamp:

Jun 28, 2016 7:16:36 AM (8 years ago)

Author:

fred.wang@free.fr

Message:

AX: Remove dead code in AccessibilityRenderObject::textUnderElement
​https://bugs.webkit.org/show_bug.cgi?id=159205

Patch by Frederic Wang <​fwang@igalia.com> on 2016-06-28
Reviewed by Joanmarie Diggs.

RenderMathMLOperator used to destroy its descendants and to replace them with an anonymous
text node wrapped inside anonymous blocks. After r202420, it just behaves as any other token
elements. Hence we remove the code in AccessibilityRenderObject::textUnderElement that was
used to handle this specific render tree structure.

No new tests, already covered by accessibility/math-text.html.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement): Remove dead code for RenderText and RenderMathMLOperator.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AccessibilityRenderObject.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-28  Frederic Wang  <fwang@igalia.com>
+
+        AX: Remove dead code in AccessibilityRenderObject::textUnderElement
+        https://bugs.webkit.org/show_bug.cgi?id=159205
+
+        Reviewed by Joanmarie Diggs.
+
+        RenderMathMLOperator used to destroy its descendants and to replace them with an anonymous
+        text node wrapped inside anonymous blocks. After r202420, it just behaves as any other token
+        elements. Hence we remove the code in AccessibilityRenderObject::textUnderElement that was
+        used to handle this specific render tree structure.
+
+        No new tests, already covered by accessibility/math-text.html.
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::textUnderElement): Remove dead code for RenderText and RenderMathMLOperator.
+
 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

@@ -633 +633 @@
 
 #if ENABLE(MATHML)
-    // Math operators create RenderText nodes on the fly that are not tied into the DOM in a reasonable way,
-    // so rangeOfContents does not work for them (nor does regular text selection).
-    if (isRenderText && m_renderer->isAnonymous() && ancestorsOfType<RenderMathMLOperator>(*m_renderer).first())
-        return downcast<RenderText>(*m_renderer).text();
     if (isAnonymousMathOperator()) {
         UChar operatorChar = downcast<RenderMathMLOperator>(*m_renderer).textContent();
         return operatorChar ? String(&operatorChar, 1) : String();
     }
-    if (is<RenderMathMLOperator>(*m_renderer) && !m_renderer->isAnonymous())
-        return downcast<RenderMathMLOperator>(*m_renderer).element().textContent();
 #endif