Changeset 202686 in webkit

Timestamp:

Jun 30, 2016 10:48:50 AM (8 years ago)

Author:

pvollan@apple.com

Message:

[Win][Debug] Assertion fails in TestWTF.
​https://bugs.webkit.org/show_bug.cgi?id=159299

Reviewed by Alex Christensen.

The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
the assertion failure. Since the variable is actually used, there is no need to use the
UNUSED_PARAM macro.

• TestWebKitAPI/Tests/WTF/UniqueRef.cpp:

(TestWebKitAPI::TEST):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WTF/UniqueRef.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-06-30  Per Arne Vollan  <pvollan@apple.com>
+
+        [Win][Debug] Assertion fails in TestWTF.
+        https://bugs.webkit.org/show_bug.cgi?id=159299
+
+        Reviewed by Alex Christensen.
+
+        The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
+        The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
+        the assertion failure. Since the variable is actually used, there is no need to use the
+        UNUSED_PARAM macro.
+
+        * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
+        (TestWebKitAPI::TEST):
+
 2016-06-30  Youenn Fablet  <youennf@gmail.com>
 

trunk/Tools/TestWebKitAPI/Tests/WTF/UniqueRef.cpp

@@ -80 +80 @@
     C i(makeUniqueRef<D>());
     
-    UNUSED_PARAM(a);
     UNUSED_PARAM(b);
     UNUSED_PARAM(c);