Changeset 202713 in webkit

Timestamp:

Jun 30, 2016 3:29:32 PM (8 years ago)

Author:

Matt Baker

Message:

Web Inspector: add pixel area column to layout timeline view
​https://bugs.webkit.org/show_bug.cgi?id=148677
<rdar://problem/22518762>

Reviewed by Timothy Hatcher.

The view can simply add the column. LayoutTimelineDataGridNode
already includes area data and cell formatting.

• UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/LayoutTimelineView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-06-30  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: add pixel area column to layout timeline view
+        https://bugs.webkit.org/show_bug.cgi?id=148677
+        <rdar://problem/22518762>
+
+        Reviewed by Timothy Hatcher.
+
+        The view can simply add the column. LayoutTimelineDataGridNode
+        already includes area data and cell formatting.
+
+        * UserInterface/Views/LayoutTimelineView.js:
+        (WebInspector.LayoutTimelineView):
+
 2016-06-30  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js

@@ -32 +32 @@
         console.assert(timeline.type === WebInspector.TimelineRecord.Type.Layout, timeline);
 
-        let columns = {type: {}, name: {}, location: {}, width: {}, height: {}, startTime: {}, totalTime: {}};
+        let columns = {type: {}, name: {}, location: {}, area: {}, width: {}, height: {}, startTime: {}, totalTime: {}};
 
         columns.name.title = WebInspector.UIString("Type");
@@ -55 +55 @@
         columns.location.title = WebInspector.UIString("Initiator");
         columns.location.width = "25%";
+
+        columns.area.title = WebInspector.UIString("Area");
+        columns.area.width = "8%";
 
         columns.width.title = WebInspector.UIString("Width");