Changeset 202779 in webkit

Timestamp:

Jul 2, 2016 10:44:42 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Synchronous preflight checker should set loading options to not use credentials
​https://bugs.webkit.org/show_bug.cgi?id=159351

Patch by Youenn Fablet <​youenn@apple.com> on 2016-07-02
Reviewed by Alex Christensen.

Like for asynchronous preflighting, synchronous preflighting loading options should disqble any credentials.

No change of behavior as preflight request is expressly set to not use credentials in
createAccessControlPreflightRequest.

• loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::doPreflight):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/CrossOriginPreflightChecker.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-02  Youenn Fablet  <youenn@apple.com>
+
+        Synchronous preflight checker should set loading options to not use credentials
+        https://bugs.webkit.org/show_bug.cgi?id=159351
+
+        Reviewed by Alex Christensen.
+
+        Like for asynchronous preflighting, synchronous preflighting loading options should disqble any credentials.
+
+        No change of behavior as preflight request is expressly set to not use credentials in
+        createAccessControlPreflightRequest.
+
+        * loader/CrossOriginPreflightChecker.cpp:
+        (WebCore::CrossOriginPreflightChecker::doPreflight):
+
 2016-07-01  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/loader/CrossOriginPreflightChecker.cpp

@@ -131 +131 @@
     ResourceResponse response;
     RefPtr<SharedBuffer> data;
-    unsigned identifier = loader.document().frame()->loader().loadResourceSynchronously(preflightRequest, loader.options().allowCredentials(), loader.options().clientCredentialPolicy(), error, response, data);
+    unsigned identifier = loader.document().frame()->loader().loadResourceSynchronously(preflightRequest, DoNotAllowStoredCredentials, DoNotAskClientForCrossOriginCredentials, error, response, data);
 
     if (!error.isNull() && response.httpStatusCode() <= 0) {