Changeset 202841 in webkit

Timestamp:

Jul 5, 2016 5:41:46 PM (8 years ago)

Author:

Chris Fleizach

Message:

AX: Image attachment in email does not show up in AX tree
​https://bugs.webkit.org/show_bug.cgi?id=159422

Reviewed by Joanmarie Diggs.

Source/WebCore:

When an image loads after the accessibility tree has already been created, the ignored status
of that image does not get updated.

Test: accessibility/image-load-on-delay.html

• rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):

LayoutTests:

• accessibility/image-load-on-delay-expected.txt: Added.
• accessibility/image-load-on-delay.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/image-load-on-delay-expected.txt (added)
• LayoutTests/accessibility/image-load-on-delay.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderImage.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-07-05  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Image attachment in email does not show up in AX tree
+        https://bugs.webkit.org/show_bug.cgi?id=159422
+
+        Reviewed by Joanmarie Diggs.
+
+        * accessibility/image-load-on-delay-expected.txt: Added.
+        * accessibility/image-load-on-delay.html: Added.
+
 2016-07-05  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-05  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Image attachment in email does not show up in AX tree
+        https://bugs.webkit.org/show_bug.cgi?id=159422
+
+        Reviewed by Joanmarie Diggs.
+
+        When an image loads after the accessibility tree has already been created, the ignored status
+        of that image does not get updated.
+
+        Test: accessibility/image-load-on-delay.html
+
+        * rendering/RenderImage.cpp:
+        (WebCore::RenderImage::imageChanged):
+
 2016-07-05  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/rendering/RenderImage.cpp

@@ -29 +29 @@
 #include "RenderImage.h"
 
+#include "AXObjectCache.h"
 #include "BitmapImage.h"
 #include "CachedImage.h"
@@ -253 +254 @@
     }
 
+    if (UNLIKELY(AXObjectCache::accessibilityEnabled())) {
+        if (AXObjectCache* cache = document().existingAXObjectCache())
+            cache->recomputeIsIgnored(this);
+    }
+
     repaintOrMarkForLayout(imageSizeChange, rect);
 }