Changeset 202888 in webkit
- Timestamp:
- Jul 6, 2016 6:32:43 PM (8 years ago)
- Location:
- trunk/Source
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r202887 r202888 1 2016-07-06 Chris Dumez <cdumez@apple.com> 2 3 [WK2][Cocoa] Disable ResourceResponse lazy initialization 4 https://bugs.webkit.org/show_bug.cgi?id=159497 5 <rdar://problem/27209066> 6 7 Reviewed by Alex Christensen. 8 9 Add method to Cocoa's ResponseResponse header to disable 10 lazy initialization. 11 12 * platform/network/cf/ResourceResponse.h: 13 * platform/network/cocoa/ResourceResponseCocoa.mm: 14 (WebCore::ResourceResponse::disableLazyInitialization): 15 1 16 2016-07-06 Brent Fulgham <bfulgham@apple.com> 2 17 -
trunk/Source/WebCore/platform/network/cf/ResourceResponse.h
r201721 r202888 69 69 } 70 70 71 #if PLATFORM(COCOA) 72 WEBCORE_EXPORT void disableLazyInitialization(); 73 #endif 74 71 75 unsigned memoryUsage() const 72 76 { -
trunk/Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm
r202121 r202888 69 69 } 70 70 71 void ResourceResponse::disableLazyInitialization() 72 { 73 lazyInit(AllFields); 74 } 75 71 76 CertificateInfo ResourceResponse::platformCertificateInfo() const 72 77 { -
trunk/Source/WebKit2/ChangeLog
r202884 r202888 1 2016-07-06 Chris Dumez <cdumez@apple.com> 2 3 [WK2][Cocoa] Disable ResourceResponse lazy initialization 4 https://bugs.webkit.org/show_bug.cgi?id=159497 5 <rdar://problem/27209066> 6 7 Reviewed by Alex Christensen. 8 9 Disable ResourceResponse lazy initialization for WebKit2 as 10 we always end up initializing all the fields anyway when 11 sending the response to the WebContent process via IPC. 12 13 Even worse, we always do a partial lazy initialization (common 14 fields only) before the IPC so we always do the initialization 15 in 2 steps. This normally would not be an issue but the 2 steps 16 actually have some overlap because both call 17 CFHTTPMessageCopyAllHeaderFields(), which is expensive (See 18 <rdar://problem/26796059>) to first get the common HTTP headers, 19 then ALL the HTTP headers. 20 21 * NetworkProcess/cocoa/NetworkSessionCocoa.mm: 22 (-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]): 23 1 24 2016-07-06 Chelsea Pugh <cpugh@apple.com> 2 25 -
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm
r202834 r202888 246 246 247 247 WebCore::ResourceResponse resourceResponse(response); 248 // Lazy initialization is not helpful in the WebKit2 case because we always end up initializing 249 // all the fields when sending the response to the WebContent process over IPC. 250 resourceResponse.disableLazyInitialization(); 251 248 252 copyTimingData([dataTask _timingData], resourceResponse.resourceLoadTiming()); 249 253 auto completionHandlerCopy = Block_copy(completionHandler);
Note: See TracChangeset
for help on using the changeset viewer.