Changeset 202939 in webkit

Timestamp:

Jul 7, 2016 3:42:43 PM (8 years ago)

Author:

achristensen@apple.com

Message:

Fix crash when sending failure message to closed WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=159526
<rdar://problem/26767037>

Reviewed by Brady Eidson.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didFailLoading):
Check to see if there is a connection before using it to send a message.
Sometimes it was null.
I think this could be tested if we had real network loading from TestWebKitAPI
by cancelling slow loads and closing WebProcesses around the same time, but no such infrastructure exists yet.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/NetworkResourceLoader.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-07-07  Alex Christensen  <achristensen@webkit.org>
+
+        Fix crash when sending failure message to closed WebProcess
+        https://bugs.webkit.org/show_bug.cgi?id=159526
+        <rdar://problem/26767037>
+
+        Reviewed by Brady Eidson.
+
+        * NetworkProcess/NetworkResourceLoader.cpp:
+        (WebKit::NetworkResourceLoader::didFailLoading):
+        Check to see if there is a connection before using it to send a message.
+        Sometimes it was null.
+        I think this could be tested if we had real network loading from TestWebKitAPI
+        by cancelling slow loads and closing WebProcesses around the same time, but no such infrastructure exists yet.
+
 2016-07-07  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp

@@ -406 +406 @@
         m_synchronousLoadData->error = error;
         sendReplyToSynchronousRequest(*m_synchronousLoadData, nullptr);
-    } else
-        send(Messages::WebResourceLoader::DidFailResourceLoad(error));
+    } else if (auto* connection = messageSenderConnection())
+        connection->send(Messages::WebResourceLoader::DidFailResourceLoad(error), 0, 0);
 
     cleanup();