Changeset 203267 in webkit


Ignore:
Timestamp:
Jul 14, 2016, 8:56:51 PM (9 years ago)
Author:
tonikitoo@webkit.org
Message:

[RTL Scrollbars] Frame scrollbars don't move to the right when text direction changes to RTL
​https://bugs.webkit.org/show_bug.cgi?id=158252

Patch by Antonio Gomes <​tonikitoo@igalia.com> on 2016-07-14
Reviewed by Myles C. Maxfield.

Source/WebCore:

When the 'dir' attribute changes either on body or on the document
element level, the associated FrameView does not trigger an update on
the frame level vertical scrollbar.

Patch adds a 'hook' so that RenderBox::styleDidChange can call in
order to get the document level scrollbar placed properly in the next
layout.

Test: fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html

fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html
fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html

  • page/FrameView.cpp:

(WebCore::FrameView::topContentDirectionDidChange):

  • page/FrameView.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

LayoutTests:

  • fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html: Added.
  • fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-expected.txt: Added.
  • fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html: Added.
  • fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2-expected.html: Added.
  • fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html: Added.
  • fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement-expected.txt: Added.
Location:
trunk
Files:
6 added
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r203266 r203267  
     12016-07-14  Antonio Gomes  <tonikitoo@igalia.com>
     2
     3        [RTL Scrollbars] Frame scrollbars don't move to the right when text direction changes to RTL
     4        https://bugs.webkit.org/show_bug.cgi?id=158252
     5
     6        Reviewed by Myles C. Maxfield.
     7
     8        * fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html: Added.
     9        * fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-expected.txt: Added.
     10        * fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html: Added.
     11        * fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2-expected.html: Added.
     12        * fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html: Added.
     13        * fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement-expected.txt: Added.
     14
    1152016-07-14  Myles C. Maxfield  <mmaxfield@apple.com>
    216

  • trunk/LayoutTests/TestExpectations

    r203266 r203267  
    974974fast/scrolling/rtl-scrollbars-listbox.html [ ImageOnlyFailure ]
    975975fast/scrolling/rtl-scrollbars-positioned-intersect-scrollbars.html [ ImageOnlyFailure ]
     976fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html [ ImageOnlyFailure ]
     977fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html [ ImageOnlyFailure ]
     978fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html [ ImageOnlyFailure ]
    976979
    977980# <a download> does not support Blobs

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r203160 r203267  
    26502650fast/scrolling/rtl-scrollbars-listbox.html [ Pass ]
    26512651fast/scrolling/rtl-scrollbars-positioned-intersect-scrollbars.html [ Pass ]
     2652fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html [ Pass ]
     2653fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html [ Pass ]
     2654fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html [ Pass ]
    26522655
    26532656# https://bugs.webkit.org/show_bug.cgi?id=156612

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r203249 r203267  
    507507[ Sierra+ ] fast/scrolling/rtl-scrollbars-listbox.html [ Pass ]
    508508[ Sierra+ ] fast/scrolling/rtl-scrollbars-positioned-intersect-scrollbars.html [ Pass ]
     509[ Sierra+ ] fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html [ Pass ]
     510[ Sierra+ ] fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html [ Pass ]
     511[ Sierra+ ] fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html [ Pass ]
    509512
    510513# <rdar://problem/25063128>

  • trunk/Source/WebCore/ChangeLog

    r203266 r203267  
     12016-07-14  Antonio Gomes  <tonikitoo@igalia.com>
     2
     3        [RTL Scrollbars] Frame scrollbars don't move to the right when text direction changes to RTL
     4        https://bugs.webkit.org/show_bug.cgi?id=158252
     5
     6        Reviewed by Myles C. Maxfield.
     7
     8        When the 'dir' attribute changes either on body or on the document
     9        element level, the associated FrameView does not trigger an update on
     10        the frame level vertical scrollbar.
     11
     12        Patch adds a 'hook' so that RenderBox::styleDidChange can call in
     13        order to get the document level scrollbar placed properly in the next
     14        layout.
     15
     16        Test: fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html
     17              fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html
     18              fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html
     19
     20        * page/FrameView.cpp:
     21        (WebCore::FrameView::topContentDirectionDidChange):
     22        * page/FrameView.h:
     23        * rendering/RenderBox.cpp:
     24        (WebCore::RenderBox::styleDidChange):
     25
    1262016-07-14  Myles C. Maxfield  <mmaxfield@apple.com>
    227

  • trunk/Source/WebCore/page/FrameView.cpp

    r202439 r203267  
    320320    m_firstVisuallyNonEmptyLayoutCallbackPending = true;
    321321    m_viewportIsStable = true;
     322    m_needsDeferredScrollbarsUpdate = false;
    322323    m_maintainScrollPositionAnchor = nullptr;
    323324}
    … …  
    11271128        tiledBacking->setTopContentInset(newTopContentInset);
    11281129}
     1130
     1131void FrameView::topContentDirectionDidChange()
     1132{
     1133    m_needsDeferredScrollbarsUpdate = true;
     1134}
     1135
     1136void FrameView::handleDeferredScrollbarsUpdateAfterDirectionChange()
     1137{
     1138    if (!m_needsDeferredScrollbarsUpdate)
     1139        return;
     1140
     1141    m_needsDeferredScrollbarsUpdate = false;
     1142
     1143    ASSERT(m_layoutPhase == InPostLayerPositionsUpdatedAfterLayout);
     1144    updateScrollbars(scrollPosition());
     1145    positionScrollbarLayers();
     1146}
    11291147   
    11301148bool FrameView::hasCompositedContent() const
    … …  
    14791497
    14801498    handleDeferredScrollUpdateAfterContentSizeChange();
     1499
     1500    handleDeferredScrollbarsUpdateAfterDirectionChange();
    14811501
    14821502    if (document.hasListenerType(Document::OVERFLOWCHANGED_LISTENER))

  • trunk/Source/WebCore/page/FrameView.h

    r202445 r203267  
    505505    void topContentInsetDidChange(float newTopContentInset);
    506506
     507    void topContentDirectionDidChange();
     508
    507509    WEBCORE_EXPORT void willStartLiveResize() override;
    508510    WEBCORE_EXPORT void willEndLiveResize() override;
    … …  
    658660    void sendResizeEventIfNeeded();
    659661
     662    void handleDeferredScrollbarsUpdateAfterDirectionChange();
     663
    660664    void updateScrollableAreaSet();
    661665
    … …  
    772776
    773777    bool m_viewportIsStable { true };
     778
     779    bool m_needsDeferredScrollbarsUpdate { false };
    774780
    775781    RefPtr<ContainerNode> m_maintainScrollPositionAnchor;

  • trunk/Source/WebCore/rendering/RenderBox.cpp

    r203252 r203267  
    402402            }
    403403            setNeedsLayoutAndPrefWidthsRecalc();
     404
     405            view().frameView().topContentDirectionDidChange();
    404406        }
    405407
Note: See TracChangeset for help on using the changeset viewer.