Changeset 204089 in webkit


Ignore:
Timestamp:
Aug 3, 2016, 11:17:38 AM (9 years ago)
Author:
eric.carlson@apple.com
Message:

Cleanup HTMLMediaElement track lists.
​https://bugs.webkit.org/show_bug.cgi?id=160470

Reviewed by Brent Fulgham.

  • html/track/AudioTrack.cpp:

(WebCore::AudioTrack::willRemove): Remove unnecessary ASSERT and NULL check.

  • html/track/TextTrackList.cpp:

(TextTrackList::~TextTrackList): Call clearElement so media element and client pointers are
cleared.

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r204088 r204089  
     12016-08-03  Eric Carlson  <eric.carlson@apple.com>
     2
     3        Cleanup HTMLMediaElement track lists.
     4        https://bugs.webkit.org/show_bug.cgi?id=160470
     5
     6        Reviewed by Brent Fulgham.
     7
     8        * html/track/AudioTrack.cpp:
     9        (WebCore::AudioTrack::willRemove): Remove unnecessary ASSERT and NULL check.
     10
     11        * html/track/TextTrackList.cpp:
     12        (TextTrackList::~TextTrackList): Call clearElement so media element and client pointers are
     13        cleared.
     14
    1152016-08-02  Ada Chan  <adachan@apple.com>
    216

  • trunk/Source/WebCore/html/track/AudioTrack.cpp

    r204050 r204089  
    168168{
    169169    ASSERT_UNUSED(trackPrivate, trackPrivate == m_private);
    170     ASSERT(mediaElement());
    171     if (mediaElement())
    172         mediaElement()->removeAudioTrack(*this);
     170    mediaElement()->removeAudioTrack(*this);
    173171}
    174172

  • trunk/Source/WebCore/html/track/TextTrackList.cpp

    r204050 r204089  
    4545TextTrackList::~TextTrackList()
    4646{
     47    clearElement();
    4748}
    4849
Note: See TracChangeset for help on using the changeset viewer.