Changeset 20409 in webkit


Ignore:
Timestamp:
Mar 22, 2007 3:08:57 PM (17 years ago)
Author:
spadma
Message:

2007-03-22 spadma

Reviewed by Zalan.
DESC: TMCN-6Z8J7S Opening a web bank application crashes the browser
​http://bugs.webkit.org/show_bug.cgi?id=13162

  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::SetPageUrlL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::SaveFormData):
Location:
S60/branches/3.1m
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • S60/branches/3.1m/WebCore/ChangeLog

    r20237 r20409  
     12007-03-22  spadma
     2
     3        Reviewed by Zalan.
     4        DESC: TMCN-6Z8J7S Opening a web bank application crashes the browser
     5        http://bugs.webkit.org/show_bug.cgi?id=13162
     6
     7        WARNING: NO TEST CASES ADDED OR CHANGED
     8
     9        * bridge/WebCoreBridge.cpp:
     10        (CWebCoreBridge::SaveDocumentState):
     11        * kwq/KWQKHTMLPart.cpp:
     12        (KWQKHTMLPart::submitForm):
     13
    114rathnasa  <sornalatha.rathnasamy@nokia.com>
    215        Reviewed by Zalan.

  • S60/branches/3.1m/WebCore/bridge/WebCoreBridge.cpp

    r19405 r20409  
    346346void CWebCoreBridge::SaveDocumentState()
    347347{
    348   // Save persisted form data
    349   if (iPart->FormValues()){
    350     Client().SaveFormData(*iPart->FormValues());
    351     iPart->clearRecordedFormValues();
    352   }
    353348// ### NOT IMPLEMENTED document state save/restore
    354349/*

  • S60/branches/3.1m/WebCore/kwq/KWQKHTMLPart.cpp

    r19283 r20409  
    796796    formData.Close();
    797797    }
    798 //    clearRecordedFormValues();
     798     // Save persisted form data
     799    if (FormValues()){
     800        _bridge->Client().SaveFormData(*FormValues());
     801    }
     802    clearRecordedFormValues();
    799803
    800804//    KWQ_UNBLOCK_EXCEPTIONS;

  • S60/branches/3.1m/WebKit/BrowserView/inc/WebKitLoader.h

    r19499 r20409  
    281281        HBufC* PageUrl() { return iPageUrl; }
    282282
    283         /**
    284         * PageUrl
    285         *
    286         * @since 3.1
    287         * @param
    288         * @return
    289         */
    290         HBufC* PrevPageUrl() { return iPrevPageUrl; }
    291283       
    292284    /**
    … …  
    481473        //
    482474        HBufC*                  iPageUrl;              // owned
    483         //
    484         HBufC*                  iPrevPageUrl;              // owned
    485475    //
    486476    CWmlDispatcher*     iWmlContentListener;    //owned

  • S60/branches/3.1m/WebKit/BrowserView/src/WebKitLoader.cpp

    r19499 r20409  
    197197    delete iPageUrl;
    198198    //
    199     delete iPrevPageUrl;
    200     //
    201199    delete iTransactionList;
    202200    //
    … …  
    814812    const TDesC& aResponseUrl )
    815813    {
    816     delete iPrevPageUrl;
    817     iPrevPageUrl = iPageUrl;
    818814    iPageUrl = aResponseUrl.AllocL();
    819815    }

  • S60/branches/3.1m/WebKit/BrowserView/src/webkitbridge.cpp

    r19499 r20409  
    720720    TRAP_IGNORE(
    721721        CFormDataManager* formManager = iFrame->WebKitView().WebKitControl().FormDataManagerL();
    722         if (formManager)
     722        if (formManager && iLoader->PageUrl())
    723723            {
    724             // closeURL is now called when receiving the response headers, not when submitting the form
    725             __ASSERT_DEBUG( iLoader->PrevPageUrl(), User::Panic( _L("WebKitLoader"), KErrGeneral ) );
    726             TPtrC url(iLoader->PrevPageUrl()->Des());
    727             formManager->SaveDataL(url,aFormValues);
     724            formManager->SaveDataL(*iLoader->PageUrl(),aFormValues);
    728725            }
    729726        );

  • S60/branches/3.1m/WebKit/ChangeLog

    r20405 r20409  
     12007-03-22  spadma
     2
     3        Reviewed by Zalan.
     4        DESC: TMCN-6Z8J7S Opening a web bank application crashes the browser
     5        http://bugs.webkit.org/show_bug.cgi?id=13162
     6
     7        * BrowserView/inc/WebKitLoader.h:
     8        * BrowserView/src/WebKitLoader.cpp:
     9        (CWebKitLoader::~CWebKitLoader):
     10        (CWebKitLoader::SetPageUrlL):
     11        * BrowserView/src/webkitbridge.cpp:
     12        (CWebKitBridge::SaveFormData):
     13
    1142007-03-21  vbradley  <vincent.bradley@nokia.com>
    215
Note: See TracChangeset for help on using the changeset viewer.