Changeset 204099 in webkit

Timestamp:

Aug 3, 2016 1:49:15 PM (8 years ago)

Author:

Matt Baker

Message:

Web Inspector: Cmd-L shortcut for Jump to Line conflicts with selecting URL of inspected page
​https://bugs.webkit.org/show_bug.cgi?id=158028
<rdar://problem/26516663>

Reviewed by Timothy Hatcher.

Remove Command-L shortcut for opening the Line Number dialog, since
we already support Control-G.

• UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor): Deleted.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SourceCodeTextEditor.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-08-03  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: Cmd-L shortcut for Jump to Line conflicts with selecting URL of inspected page
+        https://bugs.webkit.org/show_bug.cgi?id=158028
+        <rdar://problem/26516663>
+
+        Reviewed by Timothy Hatcher.
+
+        Remove Command-L shortcut for opening the Line Number dialog, since
+        we already support Control-G.
+
+        * UserInterface/Views/SourceCodeTextEditor.js:
+        (WebInspector.SourceCodeTextEditor): Deleted.
+
 2016-08-01  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js

@@ -83 +83 @@
         sourceCode.requestContent().then(this._contentAvailable.bind(this));
 
-        // FIXME: Cmd+L shortcut doesn't actually work.
-        new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Command, "L", this.showGoToLineDialog.bind(this), this.element);
         new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Control, "G", this.showGoToLineDialog.bind(this), this.element);