Changeset 204454 in webkit


Ignore:
Timestamp:
Aug 14, 2016, 2:45:49 PM (9 years ago)
Author:
mitz@apple.com
Message:

[Cocoa] Remove deprecated _WKVisitedLinkProvider declarations that aren’t needed
​https://bugs.webkit.org/show_bug.cgi?id=160846

Reviewed by Darin Adler.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _visitedLinkProvider]): Moved into WKBinaryCompatibilityIOS10

cateogry implementation, changed type to _WKVisitedLinkStore.

(-[WKWebViewConfiguration _setVisitedLinkProvider:]): Ditto.

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Removed property declaration.
  • UIProcess/API/Cocoa/_WKVisitedLinkProvider.h: Removed.
  • UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm: Moved declaration in here.
  • WebKit2.xcodeproj/project.pbxproj: Updated for header removal.
Location:
trunk/Source/WebKit2
Files:
1 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r204432 r204454  
     12016-08-14  Dan Bernstein  <mitz@apple.com>
     2
     3        [Cocoa] Remove deprecated _WKVisitedLinkProvider declarations that aren’t needed
     4        https://bugs.webkit.org/show_bug.cgi?id=160846
     5
     6        Reviewed by Darin Adler.
     7
     8        * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
     9        (-[WKWebViewConfiguration _visitedLinkProvider]): Moved into WKBinaryCompatibilityIOS10
     10          cateogry implementation, changed type to _WKVisitedLinkStore.
     11        (-[WKWebViewConfiguration _setVisitedLinkProvider:]): Ditto.
     12        * UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Removed property declaration.
     13
     14        * UIProcess/API/Cocoa/_WKVisitedLinkProvider.h: Removed.
     15        * UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm: Moved declaration in here.
     16
     17        * WebKit2.xcodeproj/project.pbxproj: Updated for header removal.
     18
    1192016-08-12  Dan Bernstein  <mitz@apple.com>
    220

  • trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm

    r203855 r204454  
    3636#import "WKWebViewContentProviderRegistry.h"
    3737#import "WeakObjCPtr.h"
    38 #import "_WKVisitedLinkProvider.h"
     38#import "_WKVisitedLinkStore.h"
    3939#import "_WKWebsiteDataStoreInternal.h"
    4040#import <WebCore/RuntimeApplicationChecks.h>
    … …  
    397397}
    398398
    399 -(_WKVisitedLinkProvider *)_visitedLinkProvider
    400 {
    401     return (_WKVisitedLinkProvider *)self._visitedLinkStore;
    402 }
    403 
    404 - (void)_setVisitedLinkProvider:(_WKVisitedLinkProvider *)_visitedLinkProvider
    405 {
    406     self._visitedLinkStore = _visitedLinkProvider;
    407 }
    408 
    409399#pragma clang diagnostic pop
    410400
    … …  
    764754@end
    765755
     756@implementation WKWebViewConfiguration (WKBinaryCompatibilityWithIOS10)
     757
     758-(_WKVisitedLinkStore *)_visitedLinkProvider
     759{
     760    return self._visitedLinkStore;
     761}
     762
     763- (void)_setVisitedLinkProvider:(_WKVisitedLinkStore *)visitedLinkProvider
     764{
     765    self._visitedLinkStore = visitedLinkProvider;
     766}
     767
     768@end
     769
    766770#endif // WK_API_ENABLED

  • trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h

    r203855 r204454  
    2929
    3030@class WKWebView;
    31 @class _WKVisitedLinkProvider;
    3231@class _WKVisitedLinkStore;
    3332@class _WKWebsiteDataStore;
    … …  
    6968#endif
    7069
    71 @property (nonatomic, strong, setter=_setVisitedLinkProvider:) _WKVisitedLinkProvider *_visitedLinkProvider WK_API_DEPRECATED_WITH_REPLACEMENT("_visitedLinkStore", macosx(10.10, WK_MAC_TBA), ios(8.0, WK_IOS_TBA));
    72 
    7370@property (nonatomic, strong, setter=_setWebsiteDataStore:) _WKWebsiteDataStore *_websiteDataStore WK_API_DEPRECATED_WITH_REPLACEMENT("websiteDataStore", macosx(10.10, 10.11), ios(8.0, 9.0));
    7471@property (nonatomic, setter=_setRequiresUserActionForAudioPlayback:) BOOL _requiresUserActionForAudioPlayback WK_API_DEPRECATED_WITH_REPLACEMENT("mediaTypesRequiringUserActionForPlayback", macosx(WK_MAC_TBA, WK_MAC_TBA), ios(WK_IOS_TBA, WK_IOS_TBA));

  • trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm

    r188891 r204454  
    2525
    2626#include "config.h"
    27 #include "_WKVisitedLinkProvider.h"
     27#include "_WKVisitedLinkStore.h"
    2828
    2929#if WK_API_ENABLED
     30
     31// Defined for binary compatibility with Safari in iOS 10.
     32
     33@interface _WKVisitedLinkProvider : _WKVisitedLinkStore
     34@end
    3035
    3136@implementation _WKVisitedLinkProvider

  • trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj

    r204318 r204454  
    166166                1A1FEC1D1627B45700700F6D /* WebConnectionMessages.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A1FEC1B1627B45700700F6D /* WebConnectionMessages.h */; };
    167167                1A2067921B8B906600C13C36 /* _WKVisitedLinkProvider.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A2067901B8B906600C13C36 /* _WKVisitedLinkProvider.mm */; };
    168                 1A2067931B8B906600C13C36 /* _WKVisitedLinkProvider.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A2067911B8B906600C13C36 /* _WKVisitedLinkProvider.h */; settings = {ATTRIBUTES = (Private, ); }; };
    169168                1A2161B011F37664008AD0F5 /* NPRuntimeObjectMap.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A2161AE11F37664008AD0F5 /* NPRuntimeObjectMap.h */; };
    170169                1A2161B111F37664008AD0F5 /* NPRuntimeObjectMap.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A2161AF11F37664008AD0F5 /* NPRuntimeObjectMap.cpp */; };
    … …  
    21452144                1A1FEC1B1627B45700700F6D /* WebConnectionMessages.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebConnectionMessages.h; sourceTree = "<group>"; };
    21462145                1A2067901B8B906600C13C36 /* _WKVisitedLinkProvider.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = _WKVisitedLinkProvider.mm; sourceTree = "<group>"; };
    2147                 1A2067911B8B906600C13C36 /* _WKVisitedLinkProvider.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = _WKVisitedLinkProvider.h; sourceTree = "<group>"; };
    21482146                1A2161AE11F37664008AD0F5 /* NPRuntimeObjectMap.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NPRuntimeObjectMap.h; sourceTree = "<group>"; };
    21492147                1A2161AF11F37664008AD0F5 /* NPRuntimeObjectMap.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = NPRuntimeObjectMap.cpp; sourceTree = "<group>"; };
    … …  
    42444242                        isa = PBXGroup;
    42454243                        children = (
    4246                                 1A2067911B8B906600C13C36 /* _WKVisitedLinkProvider.h */,
    42474244                                1A2067901B8B906600C13C36 /* _WKVisitedLinkProvider.mm */,
    42484245                                1AFB4C6C1ADF0C7800B33339 /* _WKWebsiteDataRecord.h */,
    … …  
    74467443                                2D87861D1BDB54BF00D02ABB /* _WKUserStyleSheet.h in Headers */,
    74477444                                2D8786201BDB57F500D02ABB /* _WKUserStyleSheetInternal.h in Headers */,
    7448                                 1A2067931B8B906600C13C36 /* _WKVisitedLinkProvider.h in Headers */,
    74497445                                1A81B38118BD66AD0007FDAC /* _WKVisitedLinkStore.h in Headers */,
    74507446                                1A81B38518BD673A0007FDAC /* _WKVisitedLinkStoreInternal.h in Headers */,
Note: See TracChangeset for help on using the changeset viewer.