Changeset 204518 in webkit

Timestamp:

Aug 16, 2016 12:25:57 PM (8 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Data grid has a double left border when the first column is hidden
​https://bugs.webkit.org/show_bug.cgi?id=160723
<rdar://problem/27778081>

Reviewed by Timothy Hatcher.

This patch exploits the fact hiding columns that aren't first in DataGrid don't create double
borders.

• UserInterface/Views/DataGrid.css:

(.data-grid table.header,):
(.data-grid :matches(th, td):first-child):
(@media (-webkit-min-device-pixel-ratio: 2)):

• UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DataGrid.css (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-08-16  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Data grid has a double left border when the first column is hidden
+        https://bugs.webkit.org/show_bug.cgi?id=160723
+        <rdar://problem/27778081>
+
+        Reviewed by Timothy Hatcher.
+
+        This patch exploits the fact hiding columns that aren't first in DataGrid don't create double
+        borders.
+
+        * UserInterface/Views/DataGrid.css:
+        (.data-grid table.header,):
+        (.data-grid :matches(th, td):first-child):
+        (@media (-webkit-min-device-pixel-ratio: 2)):
+        * UserInterface/Views/SourceCodeTextEditor.js:
+        (WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):
+
 2016-08-16  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css

@@ -332 +332 @@
     transform: translateX(-2.5px);
 }
+
+.data-grid table.header,
+.data-grid table.data {
+    /* Hide right border from first hidden columns. */
+    width: calc(100% + 1px);
+    margin-left: -1px;
+}
+
+.data-grid :matches(th, td):first-child {
+    border-left: 1px solid transparent;
+}
+
+@media (-webkit-min-device-pixel-ratio: 2) {
+    .data-grid table.header,
+    .data-grid table.data {
+        width: calc(100% + 0.5px);
+        margin-left: -0.5px;
+    }
+
+    .data-grid :matches(th, td):first-child {
+        border-width: 0.5px;
+    }
+}