Changeset 204577 in webkit

Timestamp:

Aug 17, 2016 3:18:36 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Extra logging for crash reason
​https://bugs.webkit.org/show_bug.cgi?id=160943

Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-17
Reviewed by Alexey Proskuryakov.

A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.

• Scripts/webkitpy/port/server_process.py:

(ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
(ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
(ServerProcess.has_crashed): Ditto.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/server_process.py (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-08-17  Jonathan Bedard  <jbedard@apple.com>
+
+        Extra logging for crash reason
+        https://bugs.webkit.org/show_bug.cgi?id=160943
+
+        Reviewed by Alexey Proskuryakov.
+
+        A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
+
+        * Scripts/webkitpy/port/server_process.py:
+        (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
+        (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
+        (ServerProcess.has_crashed): Ditto.
+
 2016-08-17  Dan Bernstein  <mitz@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/server_process.py

@@ -157 +157 @@
             # unless we already know that this is a timeout.
             if not ignore_crash:
+                _log.debug('This test marked as a crash because of a broken pipe when writing to stdin of the server process.')
                 self._crashed = True
 
@@ -256 +257 @@
                 data = self._proc.stdout.read()
                 if not data and not stopping and (self._treat_no_data_as_crash or self._proc.poll()):
+                    _log.debug('This test marked as a crash because of no data while reading stdout for the server process.')
                     self._crashed = True
                 self._output += data
@@ -262 +264 @@
                 data = self._proc.stderr.read()
                 if not data and not stopping and (self._treat_no_data_as_crash or self._proc.poll()):
+                    _log.debug('This test marked as a crash because of no data while reading stdout for the server process.')
                     self._crashed = True
                 self._error += data
@@ -302 +305 @@
     def has_crashed(self):
         if not self._crashed and self.poll():
+            _log.debug('This test marked as a crash because of failure to poll the server process.')
             self._crashed = True
             self._handle_possible_interrupt()