Changeset 204846 in webkit

Timestamp:

Aug 23, 2016 12:00:49 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: No open/copy src resource in context menu
​https://bugs.webkit.org/show_bug.cgi?id=159028

Patch by Devin Rousso <Devin Rousso> on 2016-08-23
Reviewed by Joseph Pecoraro.

• Localizations/en.lproj/localizedStrings.js:

• UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._populateTagContextMenu):
Add options in the context menu of link attributes of DOM nodes to

• Open in New Tab
• Reveal in Resources Tab
• Copy Link Address

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (3 diffs)
• UserInterface/Views/DOMTreeElement.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-08-23  Devin Rousso  <dcrousso+webkit@gmail.com>
+
+        Web Inspector: No open/copy src resource in context menu
+        https://bugs.webkit.org/show_bug.cgi?id=159028
+
+        Reviewed by Joseph Pecoraro.
+
+        * Localizations/en.lproj/localizedStrings.js:
+
+        * UserInterface/Views/DOMTreeElement.js:
+        (WebInspector.DOMTreeElement.prototype._populateTagContextMenu):
+        Add options in the context menu of link attributes of DOM nodes to
+         - Open in New Tab
+         - Reveal in Resources Tab
+         - Copy Link Address
+
 2016-08-23  Devin Rousso  <dcrousso+webkit@gmail.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -198 +198 @@
 localizedStrings["Controls"] = "Controls";
 localizedStrings["Cookies"] = "Cookies";
+localizedStrings["Copy Link Address"] = "Copy Link Address";
 localizedStrings["Copy Path to Property"] = "Copy Path to Property";
 localizedStrings["Copy Row"] = "Copy Row";
@@ -517 +518 @@
 localizedStrings["Opacity"] = "Opacity";
 localizedStrings["Open"] = "Open";
+localizedStrings["Open in New Tab"] = "Open in New Tab";
 localizedStrings["Option-click to show all units"] = "Option-click to show all units";
 localizedStrings["Option-click to show all values"] = "Option-click to show all values";
@@ -607 +609 @@
 localizedStrings["Reveal in Debugger Tab"] = "Reveal in Debugger Tab";
 localizedStrings["Reveal in Original Resource"] = "Reveal in Original Resource";
+localizedStrings["Reveal in Resources Tab"] = "Reveal in Resources Tab";
 localizedStrings["Right"] = "Right";
 localizedStrings["Role"] = "Role";

trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js

@@ -644 +644 @@
     _populateTagContextMenu(contextMenu, event)
     {
-        var node = this.representedObject;
+        let node = this.representedObject;
         if (!node.isInUserAgentShadowTree()) {
-            var attribute = event.target.enclosingNodeOrSelfWithClass("html-attribute");
+            let attribute = event.target.enclosingNodeOrSelfWithClass("html-attribute");
+
+            if (event.target && event.target.tagName === "A") {
+                let url = event.target.href;
+
+                contextMenu.appendItem(WebInspector.UIString("Open in New Tab"), () => {
+                    const frame = null;
+                    const alwaysOpenExternally = true;
+                    WebInspector.openURL(url, frame, alwaysOpenExternally);
+                });
+
+                if (WebInspector.frameResourceManager.resourceForURL(url)) {
+                    contextMenu.appendItem(WebInspector.UIString("Reveal in Resources Tab"), () => {
+                        let frame = WebInspector.frameResourceManager.frameForIdentifier(node.frameIdentifier);
+                        WebInspector.openURL(url, frame);
+                    });
+                }
+
+                contextMenu.appendItem(WebInspector.UIString("Copy Link Address"), () => {
+                    InspectorFrontendHost.copyText(url);
+                });
+
+                contextMenu.appendSeparator();
+            }
 
             // Add attribute-related actions.
@@ -657 +680 @@
 
             if (WebInspector.cssStyleManager.canForcePseudoClasses()) {
-                var pseudoSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Forced Pseudo-Classes"));
+                let pseudoSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Forced Pseudo-Classes"));
                 this._populateForcedPseudoStateItems(pseudoSubMenu);
                 contextMenu.appendSeparator();