Changeset 204860 in webkit

Timestamp:

Aug 23, 2016 2:47:20 PM (8 years ago)

Author:

Alan Bujtas

Message:

ASSERTION FAILED: hasOverflowingCell == this->hasOverflowingCell() in WebCore::RenderTableSection::computeOverflowFromCells
​https://bugs.webkit.org/show_bug.cgi?id=155702
<rdar://problem/27720731>

Reviewed by David Hyatt.

Source/WebCore:

The simplified layout path for table/section should also clear the slow path flag for visual overflow (since it recomputes
the overflow for the descendant cells).

Test: fast/table/assert-when-visual-overflow-is-cleared.html

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layout):

LayoutTests:

• fast/table/assert-when-visual-overflow-is-cleared-expected.txt: Added.
• fast/table/assert-when-visual-overflow-is-cleared.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/table/assert-when-visual-overflow-is-cleared-expected.txt (added)
• LayoutTests/fast/table/assert-when-visual-overflow-is-cleared.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderTableSection.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-08-23  Zalan Bujtas  <zalan@apple.com>
+
+        ASSERTION FAILED: hasOverflowingCell == this->hasOverflowingCell() in WebCore::RenderTableSection::computeOverflowFromCells
+        https://bugs.webkit.org/show_bug.cgi?id=155702
+        <rdar://problem/27720731>
+
+        Reviewed by David Hyatt.
+
+        * fast/table/assert-when-visual-overflow-is-cleared-expected.txt: Added.
+        * fast/table/assert-when-visual-overflow-is-cleared.html: Added.
+
 2016-08-23  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-08-23  Zalan Bujtas  <zalan@apple.com>
+
+        ASSERTION FAILED: hasOverflowingCell == this->hasOverflowingCell() in WebCore::RenderTableSection::computeOverflowFromCells
+        https://bugs.webkit.org/show_bug.cgi?id=155702
+        <rdar://problem/27720731>
+
+        Reviewed by David Hyatt.
+
+        The simplified layout path for table/section should also clear the slow path flag for visual overflow (since it recomputes
+        the overflow for the descendant cells). 
+
+        Test: fast/table/assert-when-visual-overflow-is-cleared.html
+
+        * rendering/RenderTableSection.cpp:
+        (WebCore::RenderTableSection::layout):
+
 2016-08-23  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/rendering/RenderTableSection.cpp

@@ -374 +374 @@
     ASSERT(!table()->needsSectionRecalc());
 
+    m_forceSlowPaintPathWithOverflowingCell = false;
     // addChild may over-grow m_grid but we don't want to throw away the memory too early as addChild
     // can be called in a loop (e.g during parsing). Doing it now ensures we have a stable-enough structure.