Changeset 205011 in webkit


Ignore:
Timestamp:
Aug 26, 2016 6:29:31 AM (8 years ago)
Author:
pvollan@apple.com
Message:

[Win] Warning fixes.
​https://bugs.webkit.org/show_bug.cgi?id=161077

Reviewed by Brent Fulgham.

  • css/CSSGrammar.y.includes:
  • css/RuleFeature.cpp:

(WebCore::makeAttributeSelectorKey):

  • editing/TextIterator.cpp:

(WebCore::SearchBuffer::SearchBuffer):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::textToFragment):

  • html/MediaElementSession.h:
  • platform/URL.cpp:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/network/HTTPParsers.cpp:

(WebCore::parseHTTPHeader):

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::clear):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::reset):

  • rendering/RenderText.cpp:

(WebCore::RenderText::secureText):

  • rendering/mathml/RenderMathMLToken.cpp:

(WebCore::mathVariant):

  • style/InlineTextBoxStyle.cpp:

(WebCore::visualOverflowForDecorations):

  • xml/XPathGrammar.y:
Location:
trunk/Source/WebCore
Files:
15 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r205008 r205011  
     12016-08-26  Per Arne Vollan  <pvollan@apple.com>
     2
     3        [Win] Warning fixes.
     4        https://bugs.webkit.org/show_bug.cgi?id=161077
     5
     6        Reviewed by Brent Fulgham.
     7
     8        * css/CSSGrammar.y.includes:
     9        * css/RuleFeature.cpp:
     10        (WebCore::makeAttributeSelectorKey):
     11        * editing/TextIterator.cpp:
     12        (WebCore::SearchBuffer::SearchBuffer):
     13        * html/HTMLElement.cpp:
     14        (WebCore::HTMLElement::textToFragment):
     15        * html/MediaElementSession.h:
     16        * platform/URL.cpp:
     17        * platform/graphics/ca/GraphicsLayerCA.cpp:
     18        * platform/network/HTTPParsers.cpp:
     19        (WebCore::parseHTTPHeader):
     20        * rendering/InlineIterator.h:
     21        (WebCore::InlineIterator::clear):
     22        * rendering/RenderDeprecatedFlexibleBox.cpp:
     23        (WebCore::FlexBoxIterator::reset):
     24        * rendering/RenderText.cpp:
     25        (WebCore::RenderText::secureText):
     26        * rendering/mathml/RenderMathMLToken.cpp:
     27        (WebCore::mathVariant):
     28        * style/InlineTextBoxStyle.cpp:
     29        (WebCore::visualOverflowForDecorations):
     30        * xml/XPathGrammar.y:
     31
    1322016-08-26  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
    233

  • trunk/Source/WebCore/css/CSSGrammar.y.includes

    r176157 r205011  
    4646using namespace HTMLNames;
    4747
     48#if COMPILER(MSVC)
     49// See https://msdn.microsoft.com/en-us/library/1wea5zwe.aspx
     50#pragma warning(disable: 4701)
     51#endif
     52
    4853#define YYMALLOC fastMalloc
    4954#define YYFREE fastFree

  • trunk/Source/WebCore/css/RuleFeature.cpp

    r199099 r205011  
    8888{
    8989    bool caseInsensitive = selector.attributeValueMatchingIsCaseInsensitive();
    90     unsigned matchAndCase = static_cast<unsigned>(selector.match()) << 1 | caseInsensitive;
     90    unsigned matchAndCase = static_cast<unsigned>(selector.match()) << 1 | (caseInsensitive ? 1 : 0);
    9191    return std::make_pair(selector.attributeCanonicalLocalName().impl(), std::make_pair(selector.value().impl(), matchAndCase));
    9292}

  • trunk/Source/WebCore/editing/TextIterator.cpp

    r203324 r205011  
    20052005    if ((m_options & AtWordStarts) && targetLength) {
    20062006        UChar32 targetFirstCharacter;
    2007         U16_GET(m_target, 0, 0, targetLength, targetFirstCharacter);
     2007        U16_GET(m_target, 0, 0u, targetLength, targetFirstCharacter);
    20082008        // Characters in the separator category never really occur at the beginning of a word,
    20092009        // so if the target begins with such a character, we just ignore the AtWordStart option.

  • trunk/Source/WebCore/html/HTMLElement.cpp

    r204235 r205011  
    435435
    436436        // Find next line break.
    437         UChar c;
     437        UChar c = 0;
    438438        unsigned i;
    439439        for (i = start; i < length; i++) {

  • trunk/Source/WebCore/html/MediaElementSession.h

    r203690 r205011  
    8080
    8181    // Restrictions to modify default behaviors.
    82     enum BehaviorRestrictionFlags {
     82    enum BehaviorRestrictionFlags : unsigned {
    8383        NoRestrictions = 0,
    8484        RequireUserGestureForLoad = 1 << 0,

  • trunk/Source/WebCore/platform/URL.cpp

    r204948 r205011  
    397397// in |toFind|. |toFind| should be a null-terminated string, all characters up
    398398// to the null will be searched. Returns int if not found.
    399 const unsigned notFoundUnsigned = -1;
     399const unsigned notFoundUnsigned = std::numeric_limits<unsigned>::max();
    400400static unsigned findFirstOf(StringView string, unsigned startPosition, const char* target)
    401401{

  • trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

    r203261 r205011  
    6767#include "PlatformCAAnimationWin.h"
    6868#include "PlatformCALayerWin.h"
     69#endif
     70
     71#if COMPILER(MSVC)
     72// See https://msdn.microsoft.com/en-us/library/1wea5zwe.aspx
     73#pragma warning(disable: 4701)
    6974#endif
    7075

  • trunk/Source/WebCore/platform/network/HTTPParsers.cpp

    r203899 r205011  
    671671
    672672    bool foundFirstNameChar = false;
    673     const char* namePtr;
     673    const char* namePtr = nullptr;
    674674    size_t nameSize = 0;
    675675

  • trunk/Source/WebCore/rendering/InlineIterator.h

    r204620 r205011  
    6969        setRenderer(nullptr);
    7070        setOffset(0);
    71         setNextBreakablePosition(-1);
     71        setNextBreakablePosition(std::numeric_limits<unsigned>::max());
    7272    }
    7373    void moveToStartOf(RenderObject& object)

  • trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp

    r200098 r205011  
    6161    {
    6262        m_currentChild = nullptr;
    63         m_ordinalIteration = -1;
     63        m_ordinalIteration = std::numeric_limits<unsigned>::max();
    6464    }
    6565

  • trunk/Source/WebCore/rendering/RenderText.cpp

    r204653 r205011  
    12021202
    12031203    UChar characterToReveal = 0;
    1204     unsigned revealedCharactersOffset;
     1204    unsigned revealedCharactersOffset = 0;
    12051205
    12061206    if (SecureTextTimer* timer = secureTextTimers().get(this)) {

  • trunk/Source/WebCore/rendering/mathml/RenderMathMLToken.cpp

    r204830 r205011  
    326326    // The Unicode mathematical blocks are divided into four segments: Latin, Greek, numbers and Arabic.
    327327    // In the case of the first three baseChar represents the relative order in which the characters are encoded in the Unicode mathematical block, normalised to the first character of that sequence.
    328     UChar32 baseChar;
     328    UChar32 baseChar = 0;
    329329    enum CharacterType {
    330330        Latin,
    … …  
    447447    }
    448448
    449     UChar32 tempChar;
     449    UChar32 tempChar = 0;
    450450    UChar32 newChar;
    451451    if (varType == Arabic) {

  • trunk/Source/WebCore/style/InlineTextBoxStyle.cpp

    r198858 r205011  
    114114   
    115115    float strokeThickness = textDecorationStrokeThickness(lineStyle.fontSize());
    116     float controlPointDistance;
     116    float controlPointDistance = 0;
    117117    float step;
    118     float wavyOffset;
     118    float wavyOffset = 0;
    119119       
    120120    TextDecorationStyle decorationStyle = lineStyle.textDecorationStyle();

  • trunk/Source/WebCore/xml/XPathGrammar.y

    r194496 r205011  
    3535#include "XPathVariableReference.h"
    3636
     37#if COMPILER(MSVC)
     38// See https://msdn.microsoft.com/en-us/library/1wea5zwe.aspx
     39#pragma warning(disable: 4701)
     40#endif
     41
    3742#define YYMALLOC fastMalloc
    3843#define YYFREE fastFree
Note: See TracChangeset for help on using the changeset viewer.