Changeset 205220 in webkit

Timestamp:

Aug 30, 2016 10:18:54 PM (8 years ago)

Author:

rniwa@webkit.org

Message:

Add "get" to CustomElementsRegistry
​https://bugs.webkit.org/show_bug.cgi?id=161421

Reviewed by Yusuke Suzuki.

Source/WebCore:

Add the support for "get" method on CustomElementsRegistry, which returns the constructor
of the custom element with the given name:
​https://html.spec.whatwg.org/multipage/scripting.html#dom-customelementregistry-get

Tests: fast/custom-elements/CustomElementRegistry.html

• dom/CustomElementRegistry.cpp:

(WebCore::CustomElementRegistry::get): Added.

• dom/CustomElementRegistry.h:
• dom/CustomElementRegistry.idl:

LayoutTests:

Added test cases for "get" method on CustomElementsRegistry.

• fast/custom-elements/CustomElementRegistry-expected.txt:
• fast/custom-elements/CustomElementRegistry.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/custom-elements/CustomElementRegistry-expected.txt (modified) (1 diff)
• LayoutTests/fast/custom-elements/CustomElementRegistry.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/CustomElementRegistry.cpp (modified) (1 diff)
• Source/WebCore/dom/CustomElementRegistry.h (modified) (3 diffs)
• Source/WebCore/dom/CustomElementRegistry.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-08-30  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Add "get" to CustomElementsRegistry
+        https://bugs.webkit.org/show_bug.cgi?id=161421
+
+        Reviewed by Yusuke Suzuki.
+
+        Added test cases for "get" method on CustomElementsRegistry.
+
+        * fast/custom-elements/CustomElementRegistry-expected.txt:
+        * fast/custom-elements/CustomElementRegistry.html:
+
 2016-08-30  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/LayoutTests/fast/custom-elements/CustomElementRegistry-expected.txt

@@ -18 +18 @@
 PASS customElements.define must not throw even if "observedAttributes" fails to convert if "attributeChangedCallback" is not defined 
 PASS customElements.define must define an instantiatable custom element 
+PASS CustomElementRegistry interface must have get as a method 
+PASS "get" must return undefined when the registry does not contain an entry with the given name 
+PASS "get" must return undefined when the registry does not contain an entry with the given name even if the name was not a valid custom element name 
+PASS "get" return the constructor of the entry with the given name when there is a matching entry. 
 

trunk/LayoutTests/fast/custom-elements/CustomElementRegistry.html

@@ -268 +268 @@
 }, 'customElements.define must define an instantiatable custom element');
 
+test(function () {
+    assert_true('get' in CustomElementRegistry.prototype, '"get" exists on CustomElementRegistry.prototype');
+    assert_true('get' in customElements, '"get" exists on window.customElements');
+}, 'CustomElementRegistry interface must have get as a method');
+
+test(function () {
+    assert_equals(customElements.get('a-b'), undefined);
+}, '"get" must return undefined when the registry does not contain an entry with the given name');
+
+test(function () {
+    assert_equals(customElements.get('html'), undefined);
+    assert_equals(customElements.get('span'), undefined);
+    assert_equals(customElements.get('div'), undefined);
+    assert_equals(customElements.get('g'), undefined);
+    assert_equals(customElements.get('ab'), undefined);
+}, '"get" must return undefined when the registry does not contain an entry with the given name even if the name was not a valid custom element name');
+
+test(function () {
+    assert_equals(customElements.get('existing-custom-element'), undefined);
+    class ExistingCustomElement extends HTMLElement {};
+    customElements.define('existing-custom-element', ExistingCustomElement);
+    assert_equals(customElements.get('existing-custom-element'), ExistingCustomElement);
+}, '"get" return the constructor of the entry with the given name when there is a matching entry.');
+
 </script>
 </body>

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-08-30  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Add "get" to CustomElementsRegistry
+        https://bugs.webkit.org/show_bug.cgi?id=161421
+
+        Reviewed by Yusuke Suzuki.
+
+        Add the support for "get" method on CustomElementsRegistry, which returns the constructor
+        of the custom element with the given name:
+        https://html.spec.whatwg.org/multipage/scripting.html#dom-customelementregistry-get
+
+        Tests: fast/custom-elements/CustomElementRegistry.html
+
+        * dom/CustomElementRegistry.cpp:
+        (WebCore::CustomElementRegistry::get): Added.
+        * dom/CustomElementRegistry.h:
+        * dom/CustomElementRegistry.idl:
+
 2016-08-30  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Source/WebCore/dom/CustomElementRegistry.cpp

@@ -106 +106 @@
 }
 
+JSC::JSValue CustomElementRegistry::get(const AtomicString& name)
+{
+    if (auto* elementInterface = m_nameMap.get(name))
+        return elementInterface->constructor();
+    return JSC::jsUndefined();
+}
+
 }
 

trunk/Source/WebCore/dom/CustomElementRegistry.h

@@ -36 +36 @@
 
 class JSObject;
+class JSValue;
     
 }
@@ -58 +59 @@
     bool containsConstructor(const JSC::JSObject*) const;
 
+    JSC::JSValue get(const AtomicString&);
+
 private:
     CustomElementRegistry();
@@ -65 +68 @@
     HashMap<const JSC::JSObject*, JSCustomElementInterface*> m_constructorMap;
 };
-    
+
 }
 

trunk/Source/WebCore/dom/CustomElementRegistry.idl

@@ -32 +32 @@
 
     [CEReactions, Custom] void define(DOMString name, Function constructor);
+    any get(DOMString name);
 
 };