Changeset 205326 in webkit
- Timestamp:
- Sep 1, 2016 4:04:23 PM (8 years ago)
- Location:
- trunk
- Files:
-
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r205319 r205326 1 2016-09-01 Ricky Mondello <rmondello@apple.com> 2 3 YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs 4 https://bugs.webkit.org/show_bug.cgi?id=161478 5 <rdar://problem/28050847> 6 7 Reviewed by Eric Carlson. 8 9 * platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-expected.txt: Update the URL that was blocked. 10 * platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-no-height-or-width-expected.txt: Ditto. 11 * security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement-expected.txt: Ditto. 12 1 13 2016-09-01 Devin Rousso <dcrousso+webkit@gmail.com> 2 14 -
trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-expected.txt
r203526 r205326 1 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o ?showinfo=02 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o ?showinfo=03 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US &showinfo=04 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US &showinfo=05 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o ?showinfo=01 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o 2 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o 3 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US 4 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US 5 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o 6 6 Test transforming youtube flash plugin to youtube iFrame based player. < rdar://problem/11201356> 7 7 -
trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-no-height-or-width-expected.txt
r203522 r205326 1 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o ?showinfo=02 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o ?showinfo=03 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o ?showinfo=04 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US &showinfo=05 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US &showinfo=06 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US &showinfo=01 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o 2 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o 3 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o 4 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US 5 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US 6 Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US 7 7 Test embed youtube plugin without height or width attribute. < rdar://problem/12134474> 8 8 -
trunk/LayoutTests/security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement-expected.txt
r203611 r205326 1 Blocked access to external URL https://www.youtube.com/embed/UF8uR6Z6KLc ?showinfo=01 Blocked access to external URL https://www.youtube.com/embed/UF8uR6Z6KLc 2 2 -
trunk/Source/WebCore/ChangeLog
r205324 r205326 1 2016-09-01 Ricky Mondello <rmondello@apple.com> 2 3 YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs 4 https://bugs.webkit.org/show_bug.cgi?id=161478 5 <rdar://problem/28050847> 6 7 Reviewed by Eric Carlson. 8 9 * Modules/plugins/YouTubePluginReplacement.cpp: 10 (WebCore::YouTubePluginReplacement::youTubeURLFromAbsoluteURL): Stop adding the query parameter. 11 1 12 2016-09-01 Mark Lam <mark.lam@apple.com> 2 13 -
trunk/Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp
r205306 r205326 328 328 query = possibleMalformedQuery; 329 329 330 // By default, the iframe will display information like the video title and uploader on top of the video. Don't display331 // them if the embeding html doesn't specify it.332 if (!query.isEmpty() && !query.contains("showinfo"))333 query.append("&showinfo=0");334 else335 query = "showinfo=0";336 337 330 // Append the query string if it is valid. 338 331 StringBuilder finalURL; -
trunk/Tools/ChangeLog
r205313 r205326 1 2016-09-01 Ricky Mondello <rmondello@apple.com> 2 3 YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs 4 https://bugs.webkit.org/show_bug.cgi?id=161478 5 <rdar://problem/28050847> 6 7 Reviewed by Eric Carlson. 8 9 * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp: 10 (TestWebKitAPI::TEST_F): Update expected results. 11 1 12 2016-09-01 Anders Carlsson <andersca@apple.com> 2 13 -
trunk/Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp
r205306 r205326 53 53 54 54 // Basic YouTube video links, expected to be transformed. 55 EXPECT_TRUE(test("https://www.youtube.com/v/dQw4w9WgXcQ", "https://www.youtube.com/embed/dQw4w9WgXcQ ?showinfo=0"));56 EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ", "http://www.youtube.com/embed/dQw4w9WgXcQ ?showinfo=0"));57 EXPECT_TRUE(test("https://youtube.com/v/dQw4w9WgXcQ", "https://youtube.com/embed/dQw4w9WgXcQ ?showinfo=0"));58 EXPECT_TRUE(test("http://youtube.com/v/dQw4w9WgXcQ", "http://youtube.com/embed/dQw4w9WgXcQ ?showinfo=0"));55 EXPECT_TRUE(test("https://www.youtube.com/v/dQw4w9WgXcQ", "https://www.youtube.com/embed/dQw4w9WgXcQ")); 56 EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ", "http://www.youtube.com/embed/dQw4w9WgXcQ")); 57 EXPECT_TRUE(test("https://youtube.com/v/dQw4w9WgXcQ", "https://youtube.com/embed/dQw4w9WgXcQ")); 58 EXPECT_TRUE(test("http://youtube.com/v/dQw4w9WgXcQ", "http://youtube.com/embed/dQw4w9WgXcQ")); 59 59 60 60 // With start time, preserved. 61 EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ?start=4", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4 &showinfo=0"));62 EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ?start=4&fs=1", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4&fs=1 &showinfo=0"));61 EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ?start=4", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4")); 62 EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ?start=4&fs=1", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4&fs=1")); 63 63 64 64 // With an invalid query (see & instead of ?), we preserve and fix the query. 65 EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ&start=4", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4 &showinfo=0"));66 EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ&start=4&fs=1", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4&fs=1 &showinfo=0"));65 EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ&start=4", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4")); 66 EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ&start=4&fs=1", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4&fs=1")); 67 67 68 68 // Non-Flash URL is untouched.
Note: See TracChangeset
for help on using the changeset viewer.