Changeset 205343 in webkit

Timestamp:

Sep 2, 2016 1:54:25 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Fix compiler warning in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=161529

We were missing a return statement in decidePermissionRequest() and
also there was unused variable in browserWindowConstructed().

Patch by Tomas Popela <​tpopela@redhat.com> on 2016-09-02
Reviewed by Carlos Garcia Campos.

• MiniBrowser/gtk/BrowserTab.c:

(decidePermissionRequest):

• MiniBrowser/gtk/BrowserWindow.c:

(browserWindowConstructed):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/gtk/BrowserTab.c (modified) (1 diff)
• MiniBrowser/gtk/BrowserWindow.c (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-09-02  Tomas Popela  <tpopela@redhat.com>
+
+        [GTK] Fix compiler warning in MiniBrowser
+        https://bugs.webkit.org/show_bug.cgi?id=161529
+
+        We were missing a return statement in decidePermissionRequest() and
+        also there was unused variable in browserWindowConstructed().
+
+        Reviewed by Carlos Garcia Campos.
+
+        * MiniBrowser/gtk/BrowserTab.c:
+        (decidePermissionRequest):
+        * MiniBrowser/gtk/BrowserWindow.c:
+        (browserWindowConstructed):
+
 2016-09-01  Dan Bernstein  <mitz@apple.com>
 

trunk/Tools/MiniBrowser/gtk/BrowserTab.c

@@ -226 +226 @@
     gtk_box_reorder_child(GTK_BOX(tab), dialog, 0);
     gtk_widget_show(dialog);
+
+    return TRUE;
 }
 

trunk/Tools/MiniBrowser/gtk/BrowserWindow.c

@@ -953 +953 @@
 static void browserWindowConstructed(GObject *gObject)
 {
-    BrowserWindow *window = BROWSER_WINDOW(gObject);
-
     G_OBJECT_CLASS(browser_window_parent_class)->constructed(gObject);
 }